Skip to content

fix(keyword_docs.rs): use of as keyword to disambiguate paths #143098

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iampi31415
Copy link

@iampi31415 iampi31415 commented Jun 27, 2025

  • The file keyword_docs.rs was missing documenting the use of the as keyword to disambiguate paths in trait implementations.

This is also described in the issue linked below.

There isn't a tracking issue, but there is an issue here.

Some details:

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 27, 2025
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@fmease
Copy link
Member

fmease commented Jun 27, 2025

Coincidentally someone already opened a PR a week ago: #142670.

Not sure if we should close this PR in favor of the other one or if we should wait for the older one to get merged first and then recontextualize this PR to act as a follup up / fixup.

Anyway @rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2025
@rust-log-analyzer

This comment has been minimized.

@iampi31415
Copy link
Author

iampi31415 commented Jun 27, 2025

@fmease I hadn't noticed, that's bad luck. From what I can tell this fix seems more complete and quite different content. I don't know what's the best path forward.

@iampi31415 iampi31415 marked this pull request as ready for review June 27, 2025 17:19
@rust-log-analyzer

This comment has been minimized.

@iampi31415
Copy link
Author

Current built page looks like this:

@rust-log-analyzer

This comment has been minimized.

@tshepang
Copy link
Member

can you squash these commits, given that most of them are related fixups

@iampi31415
Copy link
Author

iampi31415 commented Jun 28, 2025

can you squash these commits, given that most of them are related fixups

@tshepang yes. Is that okay? (should be a single commit now.)

@RalfJung
Copy link
Member

RalfJung commented Jun 29, 2025

Please give this PR a description that summarizes what happens here. "I fixed something in that file" is not super helpful :) Please mention at least the 'as' keyword.

@iampi31415 iampi31415 changed the title fix: keyword_docs.rs fix(std-keywords): add missing use of as keyword to disambiguate paths Jun 29, 2025
@iampi31415
Copy link
Author

iampi31415 commented Jun 29, 2025

@RalfJung thanks, sorry about that. Is now fine or still not ideal?

I changed both description and title.

@iampi31415 iampi31415 changed the title fix(std-keywords): add missing use of as keyword to disambiguate paths fix(keyword_docs.rs): use of as keyword to disambiguate paths Jun 29, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants