Update LLVM submodule #143126

dianqk · 2025-06-28T02:33:53Z

Fixes #140686, fixes #141913, fixes #142752, fixes #143399.

tests/ui/darwin-ld64.rs

dianqk · 2025-06-28T02:39:28Z

I'm currently unable to access my Mac.

@bors2 try jobs=x86_apple*,aarch64-apple

Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_apple* try-job: aarch64-apple

jieyouxu · 2025-06-28T02:39:59Z

tests/ui/darwin-ld64.rs

+// This is a regression test for https://github.com/rust-lang/rust/issues/140686.
+// Although this is a ld64(ld-classic) bug, we still need to support it
+// due to cross-compilation and support for older Xcode.


Question: do we know if ld-classic will ever be removed in newer Xcode versions?

(EDIT: actually probably nevermind, we'll then either drop this test and/or need to bump our min baseline versions anyway.)

Nobody knows. Even after removing it, we might still need a long time to get rid of the test. :(

Perhaps we could wait for new updates from Apple first, such as a fix for the ld64 bug, or the release of new linker source code.

Oh for the test I'm not too worried even if somehow say a macos image bumps the xcode version and then this test blocks full CI, in that situation this test can be disabled or removed easily.

I was just musing if ld-classic might be gone.

Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_64-apple* try-job: aarch64-apple

Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_64-apple*

dianqk · 2025-06-30T03:50:07Z

@bors2 try jobs=x86_64-apple-2

rust-bors · 2025-06-30T03:50:11Z

⌛ Trying commit 1e974cd with merge dfeb438…

To cancel the try build, run the command @bors2 try cancel.

Add a regression test for ld64 We might want a test case. r? ghost try-job: x86_64-apple-2

rust-bors · 2025-06-30T04:55:30Z

💔 Test failed

CI ❌

dianqk · 2025-07-04T15:10:31Z

r? nikic

dianqk · 2025-07-05T05:47:28Z

@jieyouxu @Kobzol Could please check what happened here?

jieyouxu · 2025-07-05T06:57:00Z

@dianqk can you try to see if cherry-picking #143474 into this PR fixes the PR CI failure?

dianqk · 2025-07-05T08:35:35Z

🟩

rust-log-analyzer · 2025-07-05T09:29:07Z

The job aarch64-gnu-llvm-19-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_bootstrap_tool
Source: src/bootstrap/src/core/builder/tests.rs:1508
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("run-make-support").render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ [check] std <host>
    1       │-[build] llvm <host>
    2     1 │ [check] rustc <host>
    3     2 │ [check] RunMakeSupport <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_bootstrap_tool' panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.43.1/src/runtime.rs:679:13:
snapshot assertion for 'check_bootstrap_tool' failed in line 1508
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_codegen
Source: src/bootstrap/src/core/builder/tests.rs:1479
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("rustc_codegen_cranelift").render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ [check] std <host>
    1       │-[build] llvm <host>
    2     1 │ [check] rustc <host>
    3     2 │ [check] cranelift <host>
    4     3 │ [check] gcc <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_codegen' panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.43.1/src/runtime.rs:679:13:
snapshot assertion for 'check_codegen' failed in line 1479
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_compiler_no_explicit_stage
Source: src/bootstrap/src/core/builder/tests.rs:1239
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("compiler").render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ [check] std <host>
    1       │-[build] llvm <host>
    2     1 │ [check] rustc <host>
    3     2 │ [check] cranelift <host>
    4     3 │ [check] gcc <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_compiler_no_explicit_stage' panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.43.1/src/runtime.rs:679:13:
snapshot assertion for 'check_compiler_no_explicit_stage' failed in line 1239
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_compiletest_stage1_libtest
Source: src/bootstrap/src/core/builder/tests.rs:1464
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("compiletest").args(&["--set",
"build.compiletest-use-stage0-libtest=false"]).render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ [check] std <host>
    1       │-[build] llvm <host>
    2     1 │ [check] rustc <host>
    3     2 │ [check] compiletest <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_compiletest_stage1_libtest' panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.43.1/src/runtime.rs:679:13:
snapshot assertion for 'check_compiletest_stage1_libtest' failed in line 1464
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_miri_no_explicit_stage
Source: src/bootstrap/src/core/builder/tests.rs:1401
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("miri").render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ [check] std <host>
    1       │-[build] llvm <host>
    2     1 │ [check] rustc <host>
    3     2 │ [check] Miri <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_miri_no_explicit_stage' panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.43.1/src/runtime.rs:679:13:
snapshot assertion for 'check_miri_no_explicit_stage' failed in line 1401
---
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: check_rust_analyzer
Source: src/bootstrap/src/core/builder/tests.rs:1494
────────────────────────────────────────────────────────────────────────────────
Expression: ctx.config("check").path("rust-analyzer").render_steps()
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ [check] std <host>
    1       │-[build] llvm <host>
    2     1 │ [check] rustc <host>
    3     2 │ [check] rust-analyzer <host>
────────────┴───────────────────────────────────────────────────────────────────
Stopped on the first failure. Run `cargo insta test` to run all snapshots.

thread 'core::builder::tests::snapshot::check_rust_analyzer' panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/insta-1.43.1/src/runtime.rs:679:13:
snapshot assertion for 'check_rust_analyzer' failed in line 1494

nikic · 2025-07-05T19:34:03Z

@bors r+ rollup=never

bors · 2025-07-05T19:34:06Z

📌 Commit 1339b90 has been approved by nikic

It is now in the queue for this repository.

bors · 2025-07-06T01:03:21Z

⌛ Testing commit 1339b90 with merge 75d5834...

bors · 2025-07-06T04:08:06Z

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 75d5834 to master...

github-actions · 2025-07-06T04:10:42Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5adb489 (parent) -> 75d5834 (this PR)

Test differences

Show 5 test diffs

Stage 1

[ui] tests/ui/darwin-ld64.rs: [missing] -> ignore (only executed when the target is x86_64-apple-darwin) (J0)

Stage 2

[ui] tests/ui/darwin-ld64.rs: [missing] -> pass (J1)
[ui] tests/ui/darwin-ld64.rs: [missing] -> ignore (only executed when the target is x86_64-apple-darwin) (J2)
[run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J3)

Additionally, 1 doctest diff were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
J1: x86_64-apple-2
J2: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J3: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 75d5834a6c571cb0455acb5128ad51118fcbf2be --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 4255.6s -> 9092.6s (113.7%)
x86_64-apple-2: 3788.5s -> 7679.9s (102.7%)
x86_64-apple-1: 6130.4s -> 10384.9s (69.4%)
dist-aarch64-linux: 5427.7s -> 8145.4s (50.1%)
pr-check-1: 1658.7s -> 2327.7s (40.3%)
x86_64-rust-for-linux: 2822.6s -> 3892.2s (37.9%)
pr-check-2: 1958.9s -> 2670.2s (36.3%)
x86_64-gnu-tools: 3600.8s -> 4749.1s (31.9%)
armhf-gnu: 5029.7s -> 6487.3s (29.0%)
x86_64-gnu-nopt: 6857.6s -> 8720.1s (27.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-06T08:27:51Z

Finished benchmarking commit (75d5834): comparison URL.

Overall result: no relevant changes - BENCHMARK(S) FAILED

@rustbot label: -perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

rustc

❗ ❗ ❗ ❗ ❗

cc @rust-lang/wg-compiler-performance

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.3%	[-1.3%, -1.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 460.95s -> 162.322s (-64.79%)
Artifact size: 372.07 MiB -> 372.06 MiB (-0.00%)

Kobzol · 2025-07-06T08:46:09Z

Hmm, I wonder what happened here. Some CI jobs were much slower, but that's expected, as they now had to build LLVM. But there were also a few test changes, which is a bit weird, not sure if that's just an artifact of us building LLVM on CI.

And the bootstrap benchmark has also time-outed. I wonder if it was unable to use download-ci-llvm for some reason 🤔 Sadly we don't currently log its output, I'll change that. We'll see what happens in the benchmark of the next master merge.

nikic · 2025-07-06T10:32:09Z

@Kobzol The compressed-debuginfo-zstd test change always happens on LLVM updates due to a difference in configuration between CI LLVM (has zstd) and that test runner (doesn't have zstd).

PaulDance · 2025-07-06T15:14:52Z

I see that this is already beta-nominated and so will follow due process, but I just wanted to say it would be nice if this was indeed backported to beta in order to avoid having to wait for 1.90 since 1.86.

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2025

workingjubilee reviewed Jun 28, 2025

View reviewed changes

tests/ui/darwin-ld64.rs Outdated Show resolved Hide resolved

dianqk force-pushed the update-llvm branch from 914dd2a to 0a22d2d Compare June 28, 2025 02:37