Rollup of 9 pull requests #143157

matthiaskrgr · 2025-06-28T20:05:34Z

Successful merges:

std::net: adding unix_socket_exclbind feature for solaris/illumos. #123476 (std::net: adding unix_socket_exclbind feature for solaris/illumos.)
Do not include NUL-terminator in computed length #142708 (Do not include NUL-terminator in computed length)
Skip unnecessary components in x64 try builds #142963 (Skip unnecessary components in x64 try builds)
rustdoc: show attributes on enum variants #142987 (rustdoc: show attributes on enum variants)
Add windows-gnullvm hosts to the manifest #143031 (Add windows-gnullvm hosts to the manifest)
update internal send_signal comment #143082 (update internal send_signal comment)
Use tidy to sort sym::* items #143110 (Use tidy to sort sym::* items)
BTreeSet: remove duplicated code by reusing from_sorted_iter #143111 (BTreeSet: remove duplicated code by reusing from_sorted_iter)
Minor Documentation Improvements #143114 (Minor Documentation Improvements)

r? @ghost
@rustbot modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl

allows to have a tigher control over the binding exclusivness of the socket.

mostly for #[non_exhaustive]

The method `BTreeSet::from_sorted_iter` was introduced in 49ccb75, but it was not consistently used throughout the codebase. As a result, some code redundantly reimplemented its logic. This commit fixes the problem.

… r=Mark-Simulacrum std::net: adding `unix_socket_exclbind` feature for solaris/illumos. allows to have a tigher control over the binding exclusivness of the socket. ACP: rust-lang/libs-team#366

… r=Mark-Simulacrum Do not include NUL-terminator in computed length This PR contains just the first commit of rust-lang#142579 which changes it so that the string length stored in the `Location` is the length of the `&str` rather than the length of the `&CStr`. Since most users will want the `&str` length, it seems better to optimize for that use-case. There should be no visible changes in the behavior or API.

Skip unnecessary components in x64 try builds We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components. r? `````@jieyouxu`````

…e-enum-v-142599, r=GuillaumeGomez rustdoc: show attributes on enum variants mostly for #[non_exhaustive] unsure if there's any attributes we should take care to *not* include, it could use `render_code_attribute` and `is_non_exhaustive` instead, if that is a concern. fixes rust-lang#142599

…Simulacrum Add windows-gnullvm hosts to the manifest I made a mistake testing rust-lang#140772 only with `rustup-toolchain-install-master` which doesn't care about the manifests. This means windows-gnullvm self-hosting will have to wait one more release, unless this change is backported to beta and a new beta release is made, which doesn't seem worth the trouble.

…t, r=Mark-Simulacrum update internal `send_signal` comment the vxwork did not have the old comment updated in rust-lang#141990 so update here; signaling -> sending signals to because the latter reads better to me.

…, r=nnethercote Use tidy to sort `sym::*` items Use tidy to sort the symbols in the invocation of `symbols!`, instead of implementing the ordering check inside the proc macro. (asked `````@nnethercote````` about this on zulip, he didn't have any reservations about making this change) This has a couple of benefits: - tidy's "version sort" (thanks to rust-lang#141311 !) is nicer than the naive-cmp sort, so, e.g. `AtomicI{8, 16, 32, 64, 128}` are properly sorted by bit width. - consistency with the rest of the repo - allows us to remove a bit of order-verifying code from the `symbols!` proc macro impl

…k-Simulacrum BTreeSet: remove duplicated code by reusing `from_sorted_iter` The method `BTreeSet::from_sorted_iter` was introduced in 49ccb75, but it was not consistently used throughout the codebase. As a result, some code redundantly reimplemented its logic. This commit fixes the problem.

Minor Documentation Improvements --- ## Description - Fixed typos and improved clarity in comments and documentation. ---

matthiaskrgr · 2025-06-28T20:07:11Z

@bors try

Rollup of 9 pull requests Successful merges: - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.) - #142708 (Do not include NUL-terminator in computed length) - #142963 (Skip unnecessary components in x64 try builds) - #142987 (rustdoc: show attributes on enum variants) - #143031 (Add windows-gnullvm hosts to the manifest) - #143082 (update internal `send_signal` comment) - #143110 (Use tidy to sort `sym::*` items) - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`) - #143114 (Minor Documentation Improvements) r? `@ghost` `@rustbot` modify labels: rollup try-job: dist-i586-gnu-i586-i686-musl

bors · 2025-06-28T20:08:23Z

⌛ Trying commit a62de82 with merge 32c9875...

bors · 2025-06-28T21:49:50Z

☀️ Try build successful - checks-actions
Build commit: 32c9875 (32c9875b286c06d72c65a23eae833e6a27e2661d)

matthiaskrgr · 2025-06-28T21:50:20Z

@bors r+ rollup=never p=5

bors · 2025-06-28T21:50:22Z

📌 Commit a62de82 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-06-28T22:13:45Z

⌛ Testing commit a62de82 with merge cf38b8e...

bors · 2025-06-29T01:15:12Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing cf38b8e to master...

rust-timer · 2025-06-29T01:17:46Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#123476	std::net: adding `unix_socket_exclbind` feature for solaris…	`032878f28b0461a6a4e678ccb056147b184cb5ef` (link)
#142708	Do not include NUL-terminator in computed length	`001a207de0ae7a0ce1aa35b330896ea7cdf981b1` (link)
#142963	Skip unnecessary components in x64 try builds	`f1e745e23708cc01c4e160fe459b92d36c67487a` (link)
#142987	rustdoc: show attributes on enum variants	`5a4fc1d662d5028f40621327eec1d2c803fe9c82` (link)
#143031	Add windows-gnullvm hosts to the manifest	`b0bad6d8afc601701ffe2a8529ab7410accba5ee` (link)
#143082	update internal `send_signal` comment	`a922a0647c321f3a8b091684f64a2b162fcb036e` (link)
#143110	Use tidy to sort `sym::*` items	`98249715e5567cbac9217006cf190405c7bef81c` (link)
#143111	BTreeSet: remove duplicated code by reusing `from_sorted_it…	`be248f238a43a57f19202246096df47a31a09236` (link)
#143114	Minor Documentation Improvements	`75465d68f442d2c717a0dbdaad1e58e4cf58c3d6` (link)

previous master: 11ad40bb83

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-29T01:18:13Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 11ad40b (parent) -> cf38b8e (this PR)

Test differences

Show 29 test diffs

Stage 1

symbols::tests::check_symbol_order: pass -> [missing] (J0)
[rustdoc] tests/rustdoc/enum/enum-variant-non_exhaustive.rs: [missing] -> pass (J1)

Stage 2

[rustdoc] tests/rustdoc/enum/enum-variant-non_exhaustive.rs: [missing] -> pass (J2)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 4437.7s -> 5193.3s (17.0%)
aarch64-apple: 4982.9s -> 4236.0s (-15.0%)
dist-aarch64-apple: 5729.1s -> 5181.3s (-9.6%)
dist-apple-various: 6052.6s -> 5558.9s (-8.2%)
x86_64-msvc-ext1: 7337.9s -> 6855.0s (-6.6%)
x86_64-rust-for-linux: 2835.5s -> 2995.2s (5.6%)
x86_64-msvc-ext2: 5470.1s -> 5774.1s (5.6%)
dist-x86_64-netbsd: 4769.2s -> 4520.2s (-5.2%)
dist-android: 2446.7s -> 2544.5s (4.0%)
x86_64-mingw-2: 6953.2s -> 7203.3s (3.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-29T04:03:40Z

Finished benchmarking commit (cf38b8e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.6%	[3.5%, 3.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	38
Regressions ❌ (secondary)	0.1%	[0.0%, 0.3%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	38

Bootstrap: 694.764s -> 693.692s (-0.15%)
Artifact size: 371.73 MiB -> 371.73 MiB (0.00%)

devnexen and others added 24 commits June 10, 2025 19:44

std::net: adding unix_socket_exclbind feature for solaris/illumos.

1bbabb7

allows to have a tigher control over the binding exclusivness of the socket.

Do not include NUL-terminator in computed length

f3383e4

Use a NonNull pointer

6a1b7df

Skip unnecessary components in x64 try builds

e0f8e86

Skip more dist components

25dee4e

Do not build GCC in fast try builds

8034154

Remove mut

58bc1dc

Add windows-gnullvm hosts to the manifest

508021a

rustdoc: show attributes on enum variants

b2be01c

mostly for #[non_exhaustive]

update internal send_signal comment

7a79454

BTreeSet: remove duplicated code by reusing from_sorted_iter

cd1713e

The method `BTreeSet::from_sorted_iter` was introduced in 49ccb75, but it was not consistently used throughout the codebase. As a result, some code redundantly reimplemented its logic. This commit fixes the problem.

Update ui.rs

9090199

Update README.md

3a34dac

Update dangling_pointer_to_raw_pointer.rs

39092cc

Use tidy to sort sym::* items

00b64f8

Rollup merge of rust-lang#123476 - devnexen:std_net_solaris_exclbind,…

7394bd5

… r=Mark-Simulacrum std::net: adding `unix_socket_exclbind` feature for solaris/illumos. allows to have a tigher control over the binding exclusivness of the socket. ACP: rust-lang/libs-team#366

Rollup merge of rust-lang#143114 - leopardracer:master, r=RalfJung

a62de82

Minor Documentation Improvements --- ## Description - Fixed typos and improved clarity in comments and documentation. ---

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Jun 28, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2025

bors merged commit cf38b8e into rust-lang:master Jun 29, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jun 29, 2025

bors mentioned this pull request Jun 29, 2025

Add socket extensions for cygwin #139524

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #143157

Rollup of 9 pull requests #143157

matthiaskrgr commented Jun 28, 2025 •

edited

Loading

Uh oh!

matthiaskrgr commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

matthiaskrgr commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

Uh oh!

Rollup of 9 pull requests #143157

Rollup of 9 pull requests #143157

Conversation

matthiaskrgr commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

matthiaskrgr commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 28, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 29, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

matthiaskrgr commented Jun 28, 2025 •

edited

Loading