Remove -Z no-opt flag, allow --opt-level override, and add -O<n> flag #14336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's been some issues in the past with getopts and optional values, if I invoke the compiler via Will that interpret |
|
You are right in this current state the patch will not work, my mistake. The reason behind this is that, using this method, you cannot maintain backwards compatibility with Following thestinger's comments it is questionable if overriding of optimisation flags is even a good idea. I propose that this should be discussed more on #7493 and that I close this PR. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
internal: add `as_slice` to `hir::Type` ~`remove_slice`~ `as_slice` is same as `remove_ref` but for slices. Though there is `as_array` which I believe was named such because it also gets the length of the array, maybe. I am still shaky on the names feel free to suggest corrections.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
-Z no-optflag from rustc, fix #13649.Also fix #7493 and in the process add
-O<n>flag in the same vein as gcc, clang, and ghc.The additional flag
-O<n>flag may not be desired, but doing it this way unifies the two optimisation flags and results in clearer code.Backwards compatibility is kept as the
-Oflag still defaults to optimisation level 2. However this only works when no other-O<n>or--opt-levelarguments are passed to rustc (is this bad?).