Skip to content

resolve: Merge NameBindingKind::Module into NameBindingKind::Res #143458

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

petrochenkov
Copy link
Contributor

This is a simplification, but also an optimization, because now we load modules from external crates in a more lazy fashion.

@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2025
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2025
bors added a commit that referenced this pull request Jul 4, 2025
resolve: Merge `NameBindingKind::Module` into `NameBindingKind::Res`

This is a simplification, but also an optimization, because now we load modules from external crates in a more lazy fashion.
@bors
Copy link
Collaborator

bors commented Jul 4, 2025

⌛ Trying commit 72a1ac4 with merge d8766c2...

@bors
Copy link
Collaborator

bors commented Jul 5, 2025

☀️ Try build successful - checks-actions
Build commit: d8766c2 (d8766c2c7b1ffb11aa0b90c2861b10fc9b1c5c85)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d8766c2): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.7% [0.2%, 3.0%] 134
Regressions ❌
(secondary)
0.5% [0.2%, 1.2%] 47
Improvements ✅
(primary)
-1.1% [-2.1%, -0.3%] 8
Improvements ✅
(secondary)
-0.5% [-1.4%, -0.1%] 51
All ❌✅ (primary) 0.6% [-2.1%, 3.0%] 142

Max RSS (memory usage)

Results (primary -2.7%, secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.3% [1.2%, 7.7%] 5
Improvements ✅
(primary)
-2.7% [-7.1%, -0.7%] 21
Improvements ✅
(secondary)
-4.1% [-12.5%, -1.2%] 80
All ❌✅ (primary) -2.7% [-7.1%, -0.7%] 21

Cycles

Results (primary 2.6%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.7%] 2
Regressions ❌
(secondary)
2.3% [0.7%, 4.1%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.4% [-9.4%, -1.9%] 9
All ❌✅ (primary) 2.6% [2.6%, 2.7%] 2

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Bootstrap: 460.645s -> 460.524s (-0.03%)
Artifact size: 372.20 MiB -> 371.76 MiB (-0.12%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 5, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2025
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 5, 2025
@bors
Copy link
Collaborator

bors commented Jul 5, 2025

⌛ Trying commit e33d621 with merge 1556320...

bors added a commit that referenced this pull request Jul 5, 2025
resolve: Merge `NameBindingKind::Module` into `NameBindingKind::Res`

This is a simplification, but also an optimization, because now we load modules from external crates in a more lazy fashion.
@bors
Copy link
Collaborator

bors commented Jul 5, 2025

☀️ Try build successful - checks-actions
Build commit: 1556320 (155632099e9c457a68936de5f744ba18b66f9fef)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1556320): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.0%, 0.8%] 9
Improvements ✅
(primary)
-0.5% [-2.1%, -0.1%] 28
Improvements ✅
(secondary)
-0.5% [-1.3%, -0.0%] 57
All ❌✅ (primary) -0.5% [-2.1%, -0.1%] 28

Max RSS (memory usage)

Results (primary -3.0%, secondary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [1.3%, 6.4%] 4
Improvements ✅
(primary)
-3.0% [-7.5%, -0.8%] 28
Improvements ✅
(secondary)
-3.8% [-13.1%, -0.8%] 119
All ❌✅ (primary) -3.0% [-7.5%, -0.8%] 28

Cycles

Results (primary -3.8%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.0% [4.4%, 5.6%] 2
Improvements ✅
(primary)
-3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)
-4.2% [-9.4%, -1.4%] 5
All ❌✅ (primary) -3.8% [-3.8%, -3.8%] 1

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 461.008s -> 459.616s (-0.30%)
Artifact size: 372.14 MiB -> 372.19 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants