Skip to content

librustc: Fix the issue with labels shadowing variable names by making #14797

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

the leading quote part of the identifier for the purposes of hygiene.

This adopts @jbclements' solution to #12512.

I'm not sure if this is a breaking change or not.

[breaking-change]

r? @alexcrichton

@huonw
Copy link
Member

huonw commented Jun 10, 2014

The issue number is incorrect: #12512

(50, Typeof, "typeof");
(51, Unsized, "unsized");
(52, Yield, "yield");
(53, Do, "do");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eew

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamings

@alexcrichton
Copy link
Member

Could you also add Closes #12512 to the commit message?

the leading quote part of the identifier for the purposes of hygiene.

This adopts @jbclements' solution to rust-lang#14539.

I'm not sure if this is a breaking change or not.

Closes rust-lang#12512.

[breaking-change]
@pcwalton
Copy link
Contributor Author

@bors: retry

ftxqxd added a commit to ftxqxd/rust that referenced this pull request Jun 16, 2014
rustdoc was previously formatting lifetimes with two apostrophes, presumably
as a result of rust-lang#14797.
bors added a commit that referenced this pull request Jun 16, 2014
rustdoc was previously formatting lifetimes with two apostrophes, presumably as a result of #14797.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
fix: Fix perf regression from symbol index refactor

Should fix the regressions introduced by rust-lang/rust-analyzer#14715 by partially rolling back the PR
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants