Rename functions in the CloneableVector trait #15725
Conversation
* Deprecated `to_owned` in favor of `to_vec` * Deprecated `into_owned` in favor of `into_vec` [breaking-change]
|
The travis build errored (timeout) so I have amended the commit without changing anything and pushed again. Hopefully it will go right this time. |
|
cc @aturon. I suppose you will find this interesting, since you are working on the libraries. |
| @@ -1273,9 +1274,9 @@ impl<'l> Visitor<DxrVisitorEnv> for DxrVisitor<'l> { | |||
| // process collected paths | |||
| for &(id, ref p, ref immut, ref_kind) in self.collected_paths.iter() { | |||
| let value = if *immut { | |||
| self.span.snippet(p.span).into_owned() | |||
| self.span.snippet(p.span).into_string() | |||
There was a problem hiding this comment.
Hmm, the snippet method seems to produce a String already, but maybe I'm missing something?
|
For the record, this patch also seems to be catching some Thanks for doing this work! |
|
I'm not sure whether the |
|
I view this as inciting a breaking change because eventually we will be removing the older functions, so we should act as if they're removed right now for rust code. In a procedural sort of sense, I highly doubt that whoever removes these deprecated functions will remember to annotate the change with a |
* Deprecated `to_owned` in favor of `to_vec` * Deprecated `into_owned` in favor of `into_vec` [breaking-change]
internal: fix automatic rustc/rustdoc lint generation Missed in rust-lang#15680: the output of `-Whelp` changed since the last run so it generated some bad rustdoc lints entries. Also preemptively fix a `-Whelp` breakage that might get merged in rust-lang#116412
to_ownedin favor ofto_vecinto_ownedin favor ofinto_vec[breaking-change]