Manual: Sort most attributes alphabetically #16428
Conversation
|
Note that these aren't the std docs, but the manual. The std docs are http://doc.rust-lang.org/std/ |
|
The lang items are hopelessly out of date anyway. The order you've proposed is fine with me though. r=me if you change it. |
mdinger
changed the title
|
@cmr: I sorted Oops about the std docs. Thanks for pointing it out. |
| These are functions: | ||
|
|
There was a problem hiding this comment.
Gotta add this blank line back
There was a problem hiding this comment.
Fixed on most recent push.
|
Lacking definitions for:
|
|
@cmr: I don't want this to just sit in the PR queue if it isn't ready and I can't fix it. Should I just drop the second commit and request review to merge or should I wait; maybe someone will fill in my missing definitions eventually. I asked on IRC for help with the definitions but I got no response. I figure it's bad etiquette to stay in the PR queue for too long without good reason. |
|
@mdinger I'm happy to r+ this without the definitions. |
|
Excellent. |
|
r=cmr |
Targetting at fixing most of #16414. Sorts these alphabetically: * [Crate-only attributes](http://doc.rust-lang.org/rust.html#crate-only-attributes) * [Function-only attributes](http://doc.rust-lang.org/rust.html#function-only-attributes) * [Miscellaneous attributes](http://doc.rust-lang.org/rust.html#miscellaneous-attributes) * [Lint check attributes](http://doc.rust-lang.org/rust.html#lint-check-attributes) * [Built-in Traits](http://doc.rust-lang.org/rust.html#built-in-traits) * [Types](http://doc.rust-lang.org/rust.html#types) * [Deriving](http://doc.rust-lang.org/rust.html#deriving) * [Compiler Features](http://doc.rust-lang.org/rust.html#compiler-features) Doesn't modify these: * [Operators](http://doc.rust-lang.org/rust.html#operators): An alternative sorting is unclear. * [Marker types](http://doc.rust-lang.org/rust.html#marker-types): Could be sorted but uncertain how. See below. * [Stability](http://doc.rust-lang.org/rust.html#stability): Already sorted by stability --- [Marker types](http://doc.rust-lang.org/rust.html#marker-types) has an extra newline above `fail_` which may throw off formatting (see #16412) or it may be for some other reason. If the newline is just a typo, I can just remove it and format this alphabetically like so: ```rust // Sorted alphabetically a_bread b_bread c_bread fail_ fail_bounds_check a_type b_type c_type ``` Marker types is listed as likely to become out of date so I don't know if this is worth doing anyway. [EDIT] modified `Marker types` now and tried to update the language items list.
Targetting at fixing most of #16414.
Sorts these alphabetically:
Doesn't modify these:
Marker types has an extra newline above
fail_which may throw off formatting (see #16412) or it may be for some other reason. If the newline is just a typo, I can just remove it and format this alphabetically like so:// Sorted alphabetically a_bread b_bread c_bread fail_ fail_bounds_check a_type b_type c_typeMarker types is listed as likely to become out of date so I don't know if this is worth doing anyway.
[EDIT] modified
Marker typesnow and tried to update the language items list.