-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Chapter 14 fixes #16471
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Chapter 14 fixes #16471
Conversation
Yes, r=me |
And thanks @EduardoBautista , you're right, this is probably cargo upgrades. |
No problem @steveklabnik. Also, I just noticed that cargo is now outputting file names like this:
instead of:
I can make the addition right now before it merges, open a separate PR, or ignore it if you already have it covered. |
Woo! That's a good change. Since nobody has actually done an r+ yet, go ahead and add it here as another commit. |
@steveklabnik Done. I also added a change to update all the version numbers. I only did the ones in chapter 14, completely forgot about the rest. |
This needs a rebase. Sorry about that! |
is kind of like `cargo build`, but it also then runs the produced exectuable. | ||
Try it out: | ||
|
||
```{notrust,ignore} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveklabnik Did you remove these lines of code from the guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figured it out...
@steveklabnik OK, should be ready. |
Thank you! |
…klabnik Just some small fixes for the guide. The cargo stuff is probably because of an update.
To be added back later once we have a fix. See rust-lang#16471 and rust-lang/rust-analyzer#16497 (comment).
fix: use 4 spaces for indentation in macro expansion Partial fix for rust-lang#16471. In the previous code, the indentation produced by macro expansion was set to 2 spaces. This PR modifies it to 4 spaces for the sake of consistency.
Just some small fixes for the guide. The cargo stuff is probably because of an update.