Remove core::any::AnyPrivate #17745
Merged
Remove core::any::AnyPrivate #17745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this affects a |
|
We should consider whether there is some other means of hiding the |
|
(another reason why we should not be marking things stable pre-1.0) |
|
This error appears to be spurious; I've rebased and successfully performed |
[Previously](rust-lang@e5da6a7), the `Any` trait was split into a private portion and an (empty) public portion, in order to hide the implementation strategy used for downcasting. However, the [new rules](rust-lang@e9ad12c) for privacy forbid `AnyPrivate` from actually being private. This patch thus reverts the introduction of `AnyPrivate`. Although this is unlikely to break any real code, it removes a public trait and is therefore a: [breaking-change]
aturon
force-pushed
the
revert-any-private
branch
from
cba4cc3 to
d007d44
Compare
bors
added a commit
that referenced
this pull request
Oct 7, 2014
[Previously](e5da6a7), the `Any` trait was split into a private portion and an (empty) public portion, in order to hide the implementation strategy used for downcasting. However, the [new rules](e9ad12c) for privacy forbid `AnyPrivate` from actually being private. This patch thus reverts the introduction of `AnyPrivate`. Although this is unlikely to break any real code, it removes a public trait and is therefore a: [breaking-change]
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
…=Veykril Improve crate manifests, adding missing `[package.repository]` and `[package.description]` fields As [discussed on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Could.20we.20add.20repository.20url.20to.20.60ra_ap_.60.20crates.20on.20crates.2Eio.3F/near/455095161). cc `@Veykril` `@lnicola`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Anytrait was split into a private portion and an (empty) public portion, in order to hide the implementation strategy used for downcasting. However, the new rules for privacy forbidAnyPrivatefrom actually being private.This patch thus reverts the introduction of
AnyPrivate.Although this is unlikely to break any real code, it removes a public trait and is therefore a:
[breaking-change]