Just testing bots #18503
Closed
Just testing bots #18503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only free function not part of the trait.
'Numeric' is the proper name of the unicode character class, and this frees up the word 'digit' for ascii use in libcore. Since I'm going to rename `Char::is_digit_radix` to `is_digit`, I am not leaving a deprecated method in place, because that would just cause name clashes, as both `Char` and `UnicodeChar` are in the prelude. [breaking-change]
This fits the naming of `to_digit` and `from_digit`. Leave the old name deprecated.
"bytes" is redundant. Deprecate the old.
Missing method to pair with len_utf8.
For now we are preferring free functions for primitive ctors, so they are marked 'unstable' pending final decision. The methods on `Char` are 'deprecated'.
Prefer the methods.
The `Char` trait itself may go away in favor of primitive inherent methods. Still some questions about whether the preconditions are following the final error handling conventions.
Consistent with current design guidelines, though it does result in a performance hit, particularly for multi-byte cases. test iter_1bytes ... bench: 341 ns/iter (+/- 90) test iter_4bytes ... bench: 944 ns/iter (+/- 204) test noiter_1bytes ... bench: 324 ns/iter (+/- 52) test noiter_4bytes ... bench: 510 ns/iter (+/- 227) [breaking-change]
Methods on primitmive Copy types generally should take `self`. [breaking-change]
|
|
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Nov 12, 2024
…olve-indexing Use completion item indices instead of property matching when searching for the completion item to resolve
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.