Implement more basic traits for the marker types. #19007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,7 +132,7 @@ pub mod marker { | |||
| /// (for example, `S<&'static int>` is a subtype of `S<&'a int>` | |||
| /// for some lifetime `'a`, but not the other way around). | |||
| #[lang="covariant_type"] | |||
| #[deriving(PartialEq,Clone)] | |||
| #[deriving(Clone,PartialEq,Eq,PartialOrd,Ord)] | |||
There was a problem hiding this comment.
Nit: Could you add spaces between the commas?
|
We should really have a lint for these. Reminds me of the hypothetical |
|
These should probably also implement |
|
r=me with some spaces added |
huonw
force-pushed
the
more-marker-impls
branch
from
86823a8 to
f975243
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for #[deriving].