Skip to content

Use the new scheme for slicing #20562

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 8 commits into from
Closed

Use the new scheme for slicing #20562

wants to merge 8 commits into from

Conversation

nrc
Copy link
Member

@nrc nrc commented Jan 5, 2015

Use index with ranges, rather than a dedicated trait and compiler support.

This is not quite ready to land - it needs a rebase and a fair bit of work to pass make tidy. But I want to get it reviewed so I can try to land it quickly once it is rebased. This is how I expect things to look, in general.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc nrc assigned huonw and unassigned pcwalton Jan 5, 2015
@huonw
Copy link
Member

huonw commented Jan 5, 2015

r=me

@nikomatsakis
Copy link
Contributor

See PR #20576 <-- my attempt to get this landed while nick's asleep :)

@nrc nrc force-pushed the arrays-3 branch 5 times, most recently from 9ab6c9a to 9e66028 Compare January 5, 2015 22:46
@nrc nrc force-pushed the arrays-3 branch 3 times, most recently from 61b061d to b2f46c5 Compare January 6, 2015 03:39
@nikomatsakis nikomatsakis added this to the 1.0 alpha milestone Jan 6, 2015
bors added a commit that referenced this pull request Jan 6, 2015
Use index with ranges, rather than a dedicated trait and compiler support.

This is not quite ready to land - it needs a rebase and a fair bit of work to pass make tidy. But I want to get it reviewed so I can try to land it quickly once it is rebased. This is how I expect things to look, in general.
@nikomatsakis
Copy link
Contributor

🐎

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 7, 2015
@alexcrichton
Copy link
Member

Merged as part of #20677

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants