Better iOS support #20699
Better iOS support #20699
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
It actually will pass all buildbots at is, but for actual compilation for aarch64 it requires rust-lang/compiler-rt#8 to land. |
|
@alexcrichton any chance to get it into alpha? |
|
Rebased after |
|
Need another rebase |
|
@tomjakubowski can you elaborate? I've built with those changes after rollup |
|
@tomjakubowski disregard prev message, fixed. |
|
At the time I commented there was a fresh merge conflict warning on the PR (and I didn't see recently pushed commits), I guess GitHub was just a bit out of sync! |
| .arg("-sdk") | ||
| .arg(sdk_name) | ||
| .spawn() { | ||
| Ok(child) => child, |
There was a problem hiding this comment.
You may want to also assert that the process exited with a 0 exit code as it may help debug when things go wrong.
|
Looks great, thanks @vhbit for the continued support here! Now that I've merged rust-lang/compiler-rt#8, do you want to throw that in as well? |
|
@alexcrichton addressed nits in new commits, will squash them later (and delete |
|
Ah I see now, looks good to me @vhbit! There's also a tidy error you may be interested in. |
|
@alexcrichton tidy error is about URL to Apple docs, what is a preffered way to fix this (leave/split/use shortener)? |
|
I'd be fine just splitting: |
- target_word_size -> target_pointer_width - added armv7 and armv7s targets - enabled building binaries so tests could be run on a jailbroken device
Now it is possible to run tests on a jailbroken device
|
@alexcrichton squashed with prev commits and cleaned up a bit |
|
Nah, one more tidy issue :( |
Changed alignment according to official Apple docs
|
Fixed (hope it's the last thing) |
Better iOS support Reviewed-by: alexcrichton
Includes fixes to ABI and also now supports almost all targets available for iOS platform: armv7, armv7s, aarch64 (arm64) for devices and i386, x86_64 for simulator. So the only missing for now are thumbv7 and thumbv7s.