Feature gate box syntax #20723

pnkfelix · 2015-01-07T23:36:15Z

Added box_syntax feature gate; added to std and rustc crates for bootstrap.

To avoid using the feature, change uses of box <expr> to Box::new(<expr>) alternative, as noted by the feature gate message.

(Note that box patterns have no analogous trivial replacement, at least not in general; you need to revise the code to do a partial match, deref, and then the rest of the match.)

[breaking-change]

rust-highfive · 2015-01-07T23:36:19Z

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

pnkfelix · 2015-01-07T23:37:09Z

(i'm still doing a local make check run now; hopefully this one will work. i had some problems with an earlier strategy I was employing and am hoping this "dead simple" approach will just work.)

pnkfelix · 2015-01-07T23:37:45Z

argh still need to pepper more crates with #![allow(unknown_feature)]

…otstrap. To avoid using the feauture, change uses of `box <expr>` to `Box::new(<expr>)` alternative, as noted by the feature gate message. (Note that box patterns have no analogous trivial replacement, at least not in general; you need to revise the code to do a partial match, deref, and then the rest of the match.) [breaking-change]

Specifically added to the test, librustc_trans, librustc_typeck crates.

…in various tests.

…tax in various tests.

feature gate net. fix typo in my feature-gate-box-expr.rs test.

aturon · 2015-01-07T23:43:05Z

@pnkfelix Talking more with the rest of the core team, we actually feel like #[stable] for Box::new is fine -- note that Rc::new and friends are already #[stable], and having a standard constructor seems like a very minimal commitment regardless of how box syntax works out.

aturon · 2015-01-07T23:56:12Z

(Thanks for getting this out so quickly btw!)

pnkfelix · 2015-01-08T00:40:30Z

(still waiting on a local make check; but i'll be tagging this with r=huonw once that is done)

…new` instead in the future.)

…ox::new` instead.)

… as prior two commits.)

pnkfelix · 2015-01-08T01:42:28Z

(handing off to acrichto to deal with remaining fallout as part of rollup)

Conflicts: src/compiletest/compiletest.rs src/libcollections/lib.rs src/libserialize/lib.rs src/libsyntax/feature_gate.rs

See rust-lang/rust#20723

Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.

…cepted, r=nikomatsakis Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.

…cepted, r=nikomatsakis Re-tag `slicing_syntax` as `Accepted`. Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.

@nrc

As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc

@nrc

As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc

@nrc

As part of the audit for rust-lang#22820 the following duplicate feature gate tests were removed: * `box_patterns` * `simd_ffi` These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578, however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively. r? @nrc

Add Box::new method. Prereq for feature-gating box <expr> itself.

82af2a1

rust-highfive assigned huonw Jan 7, 2015

pnkfelix added 8 commits January 8, 2015 00:41

Allow unknown features to bootstrap rustc with box_syntax feature.

cfeab25

Specifically added to the test, librustc_trans, librustc_typeck crates.

run-pass tests: Add feature attributes to enable box pat/expr syntax …

ef5e8fc

…in various tests.

compile-fail tests: Add feature attributes to enable box pat/expr syn…

e318125

…tax in various tests.

alternate version of coerce-match test that avoids box syntax.

c52486d

Test that box syntax, both in expressions and patterns, is caught by

b57b0e0

feature gate net. fix typo in my feature-gate-box-expr.rs test.

Switch to using Box::new in the tests in alloc::boxed.

3fd6bfa

allow unknown features in the log crate.

3010e10

pnkfelix force-pushed the feature-gate-box-syntax branch from 0d4baae to 3010e10 Compare January 7, 2015 23:45

pnkfelix added 2 commits January 8, 2015 01:03

allow box_syntax and unknown features in the rustc_llvm crate.

772cfe9

allow box_syntax and unknown features in the rustc_driver crate.

5bd88a0

pnkfelix added 4 commits January 8, 2015 01:43

allow box_syntax and unknown features in compiletest driver.

bfd6f95

fallout: run-pass tests that use box. (many could be ported to `Box::…

a7a2dd9

…new` instead in the future.)

fallout: run-fail tests that use box. (many/all could be ported to `B…

d859816

…ox::new` instead.)

fallout: part of changes to compile-fail tests. (follows same pattern…

ae4bcd4

… as prior two commits.)

pnkfelix mentioned this pull request Jan 8, 2015

Box::new requires use std::boxed::Box despite prelude injection #20730

Closed

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 8, 2015

rollup merge of rust-lang#20723: pnkfelix/feature-gate-box-syntax

373cbab

Conflicts: src/compiletest/compiletest.rs src/libcollections/lib.rs src/libserialize/lib.rs src/libsyntax/feature_gate.rs

bors merged commit ae4bcd4 into rust-lang:master Jan 8, 2015

alkor added a commit to alkor/rust-http that referenced this pull request Jan 11, 2015

Convert box to Box::new()

ea8e6c9

See rust-lang/rust#20723

msiemens mentioned this pull request Jan 11, 2015

Switch away from box expression syntax Stebalien/term#4

Merged

pnkfelix added a commit to pnkfelix/rust that referenced this pull request Feb 13, 2015

Re-tag slicing_syntax as Accepted.

d414a39

Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.

pnkfelix mentioned this pull request Feb 13, 2015

Re-tag slicing_syntax as Accepted. #22274

Merged

This was referenced Apr 20, 2015

audit: ensure every gated feature has a compile-fail test #22820

Closed

Remove duplicate feature gate tests #24751

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature gate box syntax #20723

Feature gate box syntax #20723

Uh oh!

pnkfelix commented Jan 7, 2015

Uh oh!

rust-highfive commented Jan 7, 2015

Uh oh!

pnkfelix commented Jan 7, 2015

Uh oh!

pnkfelix commented Jan 7, 2015

Uh oh!

aturon commented Jan 7, 2015

Uh oh!

aturon commented Jan 7, 2015

Uh oh!

pnkfelix commented Jan 8, 2015

Uh oh!

pnkfelix commented Jan 8, 2015

Uh oh!

Uh oh!

Feature gate box syntax #20723

Feature gate box syntax #20723

Uh oh!

Conversation

pnkfelix commented Jan 7, 2015

Uh oh!

rust-highfive commented Jan 7, 2015

Uh oh!

pnkfelix commented Jan 7, 2015

Uh oh!

pnkfelix commented Jan 7, 2015

Uh oh!

aturon commented Jan 7, 2015

Uh oh!

aturon commented Jan 7, 2015

Uh oh!

pnkfelix commented Jan 8, 2015

Uh oh!

pnkfelix commented Jan 8, 2015

Uh oh!

Uh oh!