Skip to content

Remove perl as a dependency #21242

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 21, 2015
Merged

Remove perl as a dependency #21242

merged 3 commits into from
Jan 21, 2015

Conversation

richo
Copy link
Contributor

@richo richo commented Jan 16, 2015

There's only one build-critical path in which perl is used, and it was to do a text replacement trivially achievable with sed(1).

I ported the indenter script because it appears to be used, but removed check links because it appears to be entirely out of date.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

bors referenced this pull request Jan 18, 2015
It got accidentially reverted in 44440e5.
@richo
Copy link
Contributor Author

richo commented Jan 19, 2015

Not sure what exploded here. I'll poke.

@alexcrichton
Copy link
Member

@bors: r=brson de3ea99

bors added a commit that referenced this pull request Jan 21, 2015
There's only one build-critical path in which perl is used, and it was to do a text replacement trivially achievable with sed(1).

I ported the indenter script because it [appears to be used][indenter], but removed check links because it appears to be entirely out of date.

[indenter]: https://github.com/rust-lang/rust/blob/master/src/librustc/util/common.rs#L60-70
@bors
Copy link
Collaborator

bors commented Jan 21, 2015

⌛ Testing commit de3ea99 with merge 6869645...

@bors bors merged commit de3ea99 into rust-lang:master Jan 21, 2015
@frewsxcv
Copy link
Member

Can #12913 be closed now that this has merged?

@richo
Copy link
Contributor Author

richo commented Jan 24, 2015

Yes! Thanks, that's a great catch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants