Add the build date to the reported version. #21957 #22201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
|
This is my attempt to solve the confusion around the date reported by |
|
lgtm, you can take that as r+ if you like or wait to see if anyone has a better idea... |
|
I'd like to get rid of the useless '14:38:56 -0800' part of the commit date but git doesn't seem to support printing just the date. |
|
It seems like you can print just the date using |
|
@iKevinY Thanks for the tip! |
|
I've updated the PR to not put the time and tz offset in the version. |
rustc --version says ``` rustc 1.0.0-dev (d0e82a6 2015-02-05) (built 2015-02-11) ```
|
@bors: r=nick29581 rollup |
|
🙀 You have the wrong number! Please try again with |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 14, 2015
rustc --version says ``` rustc 1.0.0-dev (d0e82a6 2015-02-05 14:38:56 -0800) (built 2015-02-11) ```
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 15, 2015
rustc --version says ``` rustc 1.0.0-dev (d0e82a6 2015-02-05 14:38:56 -0800) (built 2015-02-11) ```
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 15, 2015
rustc --version says ``` rustc 1.0.0-dev (d0e82a6 2015-02-05 14:38:56 -0800) (built 2015-02-11) ```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc --version says