Map clone

[ruuda]

This resolves #22243 for the single-letter variables that I could grep. Some occurences could not be replaced.

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[nikomatsakis]

@bors r+ c9ad0d1 rollup

[nikomatsakis]

much nicer, thanks!

[steveklabnik]

looks good to me

[Gankra]

I believe the collection ones you caught are done in #22242 as well.

Although yours got r'd first so I guess I'll go revert mine.

Unless Git is smart enough to deal with identical changes?

Regardless, it seems like you missed a lot of the occurrences in collections, perhaps there was a flaw in your search pattern? (I basically ctrl+f'd for iter().map in all the collections files since I'm bad at sed/grep).

Ah you didn't do any of map(|&x| x). Cool.

[ruuda]

Oops, no I forgot those. (And maybe some other cases that are disguised better. I grepped for map(|.| \*.) and the others.) @Ryman: do you want to take care of those in #22287?

[Ryman]

@ruud-v-a Yeah, I'll take care of them when rebasing once the rollup lands later :) I'll also try to avoid the ones @gankro has in their patch.

[Gankra]

If you exclude any path that includes collections you should be fine.

[Manishearth]

This was causing lots of failures in Steve's rollup: #22352

[Manishearth]

Failed in the rollup again. Issue with Windows specifically.

http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3322/steps/compile/logs/stdio

I recommend rollup- on this PR, needs some individual shepherding.

[Manishearth]

C:\bot\slave\auto-win-32-nopt-t\build\src\libstd\sys\windows\os.rs:307:41: 307:46 error: type `core::iter::Range<isize>` does not implement any method in scope named `len`
C:\bot\slave\auto-win-32-nopt-t\build\src\libstd\sys\windows\os.rs:307     fn len(&self) -> usize { self.range.len() }
                                                                                                               ^~~~~
C:\bot\slave\auto-win-32-nopt-t\build\src\libstd\sys\windows\thread_local.rs:247:42: 247:51 error: the trait `core::clone::Clone` is not implemented for the type `unsafe extern "C" fn(*mut u8)` [E0277]
C:\bot\slave\auto-win-32-nopt-t\build\src\libstd\sys\windows\thread_local.rs:247                 (*DTORS).iter().cloned().collect()
                                                                                                                          ^~~~~~~~~
error: aborting due to 2 previous errors
/c/bot/slave/auto-win-32-nopt-t/build/mk/target.mk:165: recipe for target 'i686-pc-windows-gnu/stage0/bin/rustlib/i686-pc-windows-gnu/lib/stamp.std' failed
make: *** [i686-pc-windows-gnu/stage0/bin/rustlib/i686-pc-windows-gnu/lib/stamp.std] Error 101

[pnkfelix]

@bors rollup-

[Gankra]

@bors rollup-

[pnkfelix]

@bors r-

[pnkfelix]

(I agree with @Manishearth , this might need to go through runs on the try-server or something.)

[ruuda]

My local test suite passed, is there anything I can do?

[pnkfelix]

@ruud-v-a are you running on a Windows machine?

If not, then it might be good for you to remove the windows-related changes, since those were what caused problems here, from what I can tell.

[ruuda]

I do have a Windows box, but I never succeeded in compiling Rust there, will try now.

[Ryman]

This (including the fix for the failure) is covered in #22287, which seems to have gotten stuck in the buildqueue, so perhaps we can just close this one off?

[Gankra]

Sounds good to me.