Audit the option and ptr types for proper integer usage
#22294
Conversation
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| /// assert_eq!(x.is_some(), true); | ||
| /// | ||
| /// let x: Option<uint> = None; | ||
| /// let x: Option<usize> = None; |
There was a problem hiding this comment.
Is there a reason to leave these as usize rather than i32? (for pedagogy against using usize randomly)
There was a problem hiding this comment.
Some of these can actually be inferred if we want i32, although I dunno if that would "mess up" the quality of the docs.
There was a problem hiding this comment.
I figured the explicit types were there for a reason (in particular, type inference is hard on the reader, and these docs are largely targeting total newbies). In that case, I don't know that it matters what type is there. But I guess I can change it to u32 or i32.
|
Looks good, although there are a lot of examples using r=me all except that one are changed to |
|
@huonw updated the option examples and threw on a few more modules. |
|
@bors r+ 6171 rollup |
cc #22240