Handle RUST_TEST_NOCAPTURE in compiletest and set add if to run env #22371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This patch also adds |
|
@bors: r+ ebe7f1 rollup. Thanks! I think let's leave it requiring |
|
🙀 You have the wrong number! Please try again with |
|
@bors: r+ 9ebe7f1 rollup |
|
This causes a failure of run-fail/test-tasks-invalid-value.rs (http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3610/steps/test/logs/stdio) (The test itself sets the |
fhahn
force-pushed
the
issue-17829-compiletest-nocapture
branch
from
9ebe7f1 to
ef1308c
Compare
|
@ Manishearth thanks! I have updated the patch to only set |
bombless
added a commit
to bombless/rust
that referenced
this pull request
Feb 23, 2015
…ture, r=Manishearth This is a patch for rust-lang#17829. In `compiletest` there are multiple layers which capture the output. The first layer is `run_tests_console` which is used to execute all tests. Then there are some tests that contain unit tests, which by default also captures output. Therefore `compiletest` adds `RUST_TEST_NOCAPTURE` (and `RUST_TEST_TASKS` for completeness) to the run environment of the task. Finally, the task used to execute a test redirects stdout and stdin. At the moment, the `VERBOSE=1` prints all captured output of the task (but has to print stdout and stderr separately). So at the moment using `RUST_TEST_NOCAPTURE=1` only makes sense when also using `VERBOSE=1` which seems a little bit cumbersome. Should I update the patch to only print the output of the tasks that actually execute the test (`VERBOSE=1` includes other stuff, like the output of the task used to compile the test)? This will probably involve adding an extra flag to some functions in `src/compiletest/runtest.rs` to distinguish compilation runs from runs that execute the actual tests.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 23, 2015
…ture, r=Manishearth This is a patch for rust-lang#17829. In `compiletest` there are multiple layers which capture the output. The first layer is `run_tests_console` which is used to execute all tests. Then there are some tests that contain unit tests, which by default also captures output. Therefore `compiletest` adds `RUST_TEST_NOCAPTURE` (and `RUST_TEST_TASKS` for completeness) to the run environment of the task. Finally, the task used to execute a test redirects stdout and stdin. At the moment, the `VERBOSE=1` prints all captured output of the task (but has to print stdout and stderr separately). So at the moment using `RUST_TEST_NOCAPTURE=1` only makes sense when also using `VERBOSE=1` which seems a little bit cumbersome. Should I update the patch to only print the output of the tasks that actually execute the test (`VERBOSE=1` includes other stuff, like the output of the task used to compile the test)? This will probably involve adding an extra flag to some functions in `src/compiletest/runtest.rs` to distinguish compilation runs from runs that execute the actual tests.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for #17829.
In
compiletestthere are multiple layers which capture the output. The first layer isrun_tests_consolewhich is used to execute all tests.Then there are some tests that contain unit tests, which by default also captures output. Therefore
compiletestaddsRUST_TEST_NOCAPTURE(andRUST_TEST_TASKSfor completeness) to the run environment of the task.Finally, the task used to execute a test redirects stdout and stdin. At the moment, the
VERBOSE=1prints all captured output of the task (but has to print stdout and stderr separately). So at the moment usingRUST_TEST_NOCAPTURE=1only makes sense when also usingVERBOSE=1which seems a little bit cumbersome.Should I update the patch to only print the output of the tasks that actually execute the test (
VERBOSE=1includes other stuff, like the output of the task used to compile the test)? This will probably involve adding an extra flag to some functions insrc/compiletest/runtest.rsto distinguish compilation runs from runs that execute the actual tests.