Skip to content

std: Deprecate the std::old_io::net primitives #22813

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2015
Merged

std: Deprecate the std::old_io::net primitives #22813

merged 1 commit into from
Mar 7, 2015

Conversation

alexcrichton
Copy link
Member

The std::net primitives should be ready for use now and as a result the old
ones are now deprecated and slated for removal. Most TCP/UDP functionality is
now available through std::net but the std::old_io::net::pipe module is
removed entirely from the standard library.

Unix socket funtionality can be found in sfackler's unix_socket crate
and there is currently no replacement for named pipes on Windows.

[breaking-change]

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Feb 25, 2015
@aturon aturon mentioned this pull request Feb 25, 2015
Closed
91 tasks
@aturon
Copy link
Member

aturon commented Mar 5, 2015

@bors: r+ d99097b

@bors
Copy link
Collaborator

bors commented Mar 5, 2015

⌛ Testing commit d99097b with merge 119a578...

@bors
Copy link
Collaborator

bors commented Mar 5, 2015

💔 Test failed - auto-linux-32-opt

@Manishearth
Copy link
Member

(failure because of rollup)

@Manishearth
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 5, 2015

@bors r=Manishearth d99097b

@alexcrichton
Copy link
Member Author

@bors: r=aturon d99097b5427e36f850ae30145b6d677a2a194ebc

@alexcrichton
Copy link
Member Author

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 6, 2015

⌛ Testing commit d99097b with merge b284266...

@bors
Copy link
Collaborator

bors commented Mar 6, 2015

💔 Test failed - auto-linux-64-x-android-t

@Manishearth
Copy link
Member 

/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/lib.rs:116:12: 116:26 warning: feature is deprecated and will only be available for a limited time, please rewrite code that relies on it
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/lib.rs:116 #![feature(old_impl_check)]
                                                                                                         ^~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/lib.rs:116:12: 116:26 warning: feature is deprecated and will only be available for a limited time, please rewrite code that relies on it
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/lib.rs:116 #![feature(old_impl_check)]
                                                                                                         ^~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/old_io/mod.rs:1618:10: 1618:11 warning: the type parameter `T` is not constrained by the impl trait, self type, or predicates
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/old_io/mod.rs:1618 impl<'a, T, A: ?Sized + Acceptor<T>> Iterator for IncomingConnections<'a, A> {
                                                                                                               ^
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:76:18: 76:47 error: use of deprecated item: will be removed to be reintroduced at a later date; in the meantime consider using the `unix_socket` crate for unix sockets; there is currently no replacement for named pipes, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:76 impl AsRawFd for old_io::net::pipe::UnixStream {
                                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:82:18: 82:49 error: use of deprecated item: will be removed to be reintroduced at a later date; in the meantime consider using the `unix_socket` crate for unix sockets; there is currently no replacement for named pipes, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:82 impl AsRawFd for old_io::net::pipe::UnixListener {
                                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:88:18: 88:49 error: use of deprecated item: will be removed to be reintroduced at a later date; in the meantime consider using the `unix_socket` crate for unix sockets; there is currently no replacement for named pipes, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:88 impl AsRawFd for old_io::net::pipe::UnixAcceptor {
                                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:94:18: 94:45 error: use of deprecated item: replaced with new I/O primitives in `std::net`, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:94 impl AsRawFd for old_io::net::tcp::TcpStream {
                                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:100:18: 100:47 error: use of deprecated item: replaced with new I/O primitives in `std::net`, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:100 impl AsRawFd for old_io::net::tcp::TcpListener {
                                                                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:106:18: 106:47 error: use of deprecated item: replaced with new I/O primitives in `std::net`, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:106 impl AsRawFd for old_io::net::tcp::TcpAcceptor {
                                                                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:112:18: 112:45 error: use of deprecated item: replaced with new I/O primitives in `std::net`, #[deny(deprecated)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/ext.rs:112 impl AsRawFd for old_io::net::udp::UdpSocket {
                                                                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to 7 previous errors
make: *** [x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/stamp.std] Error 101

@alexcrichton
std: Deprecate the std::old_io::net primitives
9aea749 
The `std::net` primitives should be ready for use now and as a result the old
ones are now deprecated and slated for removal. Most TCP/UDP functionality is
now available through `std::net` but the `std::old_io::net::pipe` module is
removed entirely from the standard library.

Unix socket funtionality can be found in sfackler's [`unix_socket`][unix] crate
and there is currently no replacement for named pipes on Windows.

[unix]: https://crates.io/crates/unix_socket

[breaking-change]
@alexcrichton
Copy link
Member Author

@bors: r=aturon 9aea749

@bors
Copy link
Collaborator

bors commented Mar 6, 2015

⌛ Testing commit 9aea749 with merge 50a7540...

@bors
Copy link
Collaborator

bors commented Mar 6, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Mar 6, 2015

⌛ Testing commit 9aea749 with merge ac82fbf...

@bors
Copy link
Collaborator

bors commented Mar 6, 2015

⛄ The build was interrupted to prioritize another pull request.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 6, 2015
@alexcrichton
rollup merge of rust-lang#22813: alexcrichton/deprecate-net
fd86a01 
The `std::net` primitives should be ready for use now and as a result the old
ones are now deprecated and slated for removal. Most TCP/UDP functionality is
now available through `std::net` but the `std::old_io::net::pipe` module is
removed entirely from the standard library.

Unix socket funtionality can be found in sfackler's [`unix_socket`][unix] crate
and there is currently no replacement for named pipes on Windows.

[unix]: https://crates.io/crates/unix_socket

[breaking-change]
@bors
Copy link
Collaborator

bors commented Mar 7, 2015

⌛ Testing commit 9aea749 with merge f260e08...

@bors
Copy link
Collaborator

bors commented Mar 7, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Mar 7, 2015

⌛ Testing commit 9aea749 with merge 4b6d646...

@bors
Copy link
Collaborator

bors commented Mar 7, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Collaborator

bors commented Mar 7, 2015

⌛ Testing commit 9aea749 with merge d640c8a...

@bors
Copy link
Collaborator

bors commented Mar 7, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors bors merged commit 9aea749 into rust-lang:master Mar 7, 2015
@alexcrichton alexcrichton deleted the deprecate-net branch March 7, 2015 06:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @aturon @bors @Manishearth @nikomatsakis