Skip to content

Rename LintPass::check_trait_method to check_trait_item #22821

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Rename LintPass::check_trait_method to check_trait_item #22821

merged 1 commit into from
Mar 2, 2015

Conversation

ipetkov
Copy link
Contributor

@ipetkov ipetkov commented Feb 26, 2015

Traits can have associated types and not just methods. This
clarification reflects the the type of the input the method accepts.

[breaking-change]

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Collaborator

bors commented Feb 28, 2015

☔ The latest upstream changes (presumably #22801) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member

eddyb commented Feb 28, 2015

@bors r+ 185373f rollup (with merge conflicts fixed)

@Manishearth
Copy link
Member

Needs Manishearth@057aceb

@Manishearth
Copy link
Member

Ignore that, wrong PR

Traits can have associated types and not just methods. This
clarification reflects the the type of the input the method accepts.

[breaking-change]
@ipetkov
Copy link
Contributor Author

ipetkov commented Feb 28, 2015

@eddyb updated and rebased for current master

@eddyb
Copy link
Member

eddyb commented Feb 28, 2015

@bors r+ 2fc6224

@bors
Copy link
Collaborator

bors commented Feb 28, 2015

⌛ Testing commit 2fc6224 with merge 86cf629...

bors added a commit that referenced this pull request Feb 28, 2015
Traits can have associated types and not just methods. This
clarification reflects the the type of the input the method accepts.

[breaking-change]
@bors
Copy link
Collaborator

bors commented Mar 1, 2015

💔 Test failed - auto-win-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry clean

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
 Traits can have associated types and not just methods. This
clarification reflects the the type of the input the method accepts.

[breaking-change]
@bors bors merged commit 2fc6224 into rust-lang:master Mar 2, 2015
@ipetkov ipetkov deleted the lint-method-rename branch March 2, 2015 07:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants