Add read_all to std:io::Read to parallel write_all in std::io::Write. #23369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Needs an RFC. |
|
RFC: rust-lang/rfcs#980 |
novalis
force-pushed
the
dturner/read_all
branch
from
8dfa610 to
c69ea54
Compare
|
☔ The latest upstream changes (presumably #23430) made this pull request unmergeable. Please resolve the merge conflicts. |
In the event of EOF, read_all returns a result with the new error ShortRead(number of bytes successfully read). Fixes rust-lang#23174
novalis
force-pushed
the
dturner/read_all
branch
from
c69ea54 to
a47d04a
Compare
|
What's the status of this? |
|
@archshift, seems that this will get merged once the RFC is accepted. |
| /// particular number of bytes but only a smaller number of bytes could be | ||
| /// read. | ||
| #[stable(feature = "rust1", since = "1.0.0")] | ||
| ShortRead(usize), |
There was a problem hiding this comment.
This changes the size of the enum dramatically.
|
I'm going to close this in favor of the associated RFC, but we can certainly reopen if it's accepted! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23174