Skip to content

Rollup of PRs in the queue; Sunday #23593

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 23, 2015
Merged

Rollup of PRs in the queue; Sunday #23593

merged 16 commits into from
Mar 23, 2015

Conversation

Manishearth
Copy link
Member

(yay, no Saturday)

Ms2ger and others added 8 commits March 20, 2015 13:29
@Ms2ger
Update librustc's README.txt for some code changes and reformat it.
41a7177
@Ms2ger
Make librustc's markdown README.txt claim to be markdown.
3bdb5c3 
This allows github to render it with formatting.
@steveklabnik
environment variables -> environment
8f0de74 
As @sanxiyn says,
rust-lang#23527 (comment)
@aturon
Future-proof indexing on maps: remove IndexMut
5fe0bb7 
This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in
order to future-proof the API against the eventual inclusion of an
`IndexSet` trait.

Ideally, we would eventually be able to support:

```rust
map[owned_key] = val;
map[borrowed_key].mutating_method(arguments);
&mut map[borrowed_key];
```

but to keep the design space as unconstrained as possible, we do not
currently want to support `IndexMut`, in case some other strategy will
eventually be needed.

Code currently using mutating index notation can use `get_mut` instead.

[breaking-change]

Closes rust-lang#23448
@steveklabnik
Remove manual numbers from TRPL
9acdcba 
Rustbook already does this.
@barosl
Fix documentation for std::sync::mutex: into_guard -> into_inner
84b14c5
@fhahn
Add tests checking that a number of feature gates are gating their f…
c48bb85 
…eatures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

 cc rust-lang#22820
@dotdash
Fix volatile / atomic ops on bools and small aggregates
d4ca1cf 
Boolean values and small aggregates have a different type in
args/allocas than in SSA values but the intrinsics for volatile and
atomic ops were missing the necessary casts to handle that.

Fixes rust-lang#23550
@Manishearth
Copy link
Member Author

@bors: r+ p=20

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

📌 Commit e7d77cf has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors: force

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

⌛ Testing commit e7d77cf with merge 1d1f2c0...

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

💔 Test failed - auto-mac-64-nopt-t

@dotdash
Copy link
Contributor

dotdash commented Mar 21, 2015

@bors retry

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

⌛ Testing commit e7d77cf with merge 1c15687...

@bors
Copy link
Collaborator

bors commented Mar 21, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

⌛ Testing commit e7d77cf with merge 28a5342...

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

⛄ The build was interrupted to prioritize another pull request.

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

⌛ Testing commit e7d77cf with merge bd0881a...

bors added a commit that referenced this pull request Mar 22, 2015
@bors
Auto merge of #23593 - Manishearth:rollup, r=Manishearth
bd0881a 
(yay, no Saturday)
@bors
Copy link
Collaborator

bors commented Mar 22, 2015

💔 Test failed - auto-mac-32-opt

@Manishearth
Copy link
Member Author

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

⌛ Testing commit e7d77cf with merge 34ead18...

@bors
Copy link
Collaborator

bors commented Mar 22, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Rollup merge of rust-lang#23559 - aturon:future-proof-map-index, r=Ga…
a91eece 
…nkro

 This commit removes the `IndexMut` impls on `HashMap` and `BTreeMap`, in
order to future-proof the API against the eventual inclusion of an
`IndexSet` trait.

Ideally, we would eventually be able to support:

```rust
map[owned_key] = val;
map[borrowed_key].mutating_method(arguments);
&mut map[borrowed_key];
```

but to keep the design space as unconstrained as possible, we do not
currently want to support `IndexMut`, in case some other strategy will
eventually be needed.

Code currently using mutating index notation can use `get_mut` instead.

[breaking-change]

Closes rust-lang#23448

r? @gankro
@Manishearth
Rollup merge of rust-lang#23570 - dotdash:issue23550, r=eddyb
d8baa01 
 Boolean values and small aggregates have a different type in args/allocas than
in SSA values but the intrinsics for volatile and atomic ops were
missing the necessary casts to handle that.

Fixes rust-lang#23550
@Manishearth
Rollup merge of rust-lang#23578 - fhahn:issue-22820-feature-gate-test…
718fe3d 
…s1, r=alexcrichton

 ...ures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

cc rust-lang#22820
@Manishearth
Rollup merge of rust-lang#23554 - Ms2ger:readme-rustc, r=steveklabnik
420bf9d
@Manishearth
Rollup merge of rust-lang#23555 - steveklabnik:environment, r=sanxiyn
78b61be 
 As @sanxiyn says,
rust-lang#23527 (comment)
@Manishearth
Rollup merge of rust-lang#23562 - steveklabnik:fix_book_numbers, r=al…
f5782fa 
…excrichton

 Rustbook already does this.
@Manishearth
Rollup merge of rust-lang#23576 - barosl:mutex-doc, r=alexcrichton
5b9e87b
@Manishearth
Rollup merge of rust-lang#23590 - FuGangqiang:attr, r=alexcrichton
b4e9106
bors added a commit that referenced this pull request Mar 23, 2015
@bors
Auto merge of #23593 - Manishearth:rollup, r=Manishearth
809a554 
(yay, no Saturday)
@bors
Copy link
Collaborator

bors commented Mar 23, 2015

⌛ Testing commit b4e9106 with merge 809a554...

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

💔 Test failed - auto-win-64-nopt-t

@barosl
Copy link
Contributor

barosl commented Mar 23, 2015

Wow, this rollup is very, very unfortunate!

@Manishearth
Copy link
Member Author

@bors: retry

@Manishearth
Copy link
Member Author

@barosl Most of this is just because buildbot died over the weekend.

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

💔 Test failed - auto-win-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

⚡ Previous build results for auto-linux-64-nopt-t, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t...

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

💔 Test failed - auto-win-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt are reusable. Rebuilding only auto-win-32-nopt-t...

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

1 similar comment
@bors
Copy link
Collaborator

bors commented Mar 23, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit b4e9106 into rust-lang:master Mar 23, 2015
This was referenced Mar 23, 2015
Merged
Merged
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Manishearth @bors @dotdash @alexcrichton @barosl @Centril @Ms2ger @steveklabnik @aturon @fhahn