Add an example for FromIterator::from_iter #23816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #23300) made this pull request unmergeable. Please resolve the merge conflicts. |
frewsxcv
force-pushed
the
fromiterator-example
branch
from
b96d6df to
b7ae349
Compare
|
/cc @steveklabnik since this is docs related |
|
This looks good to me. r=me with or without the following change: While we're at it, could we have an example that uses |
frewsxcv
force-pushed
the
fromiterator-example
branch
from
b7ae349 to
f6d1ad8
Compare
|
@Manishearth How's that? |
| /// let colors_set = colors_vec.into_iter().collect::<HashSet<&str>>(); | ||
| /// assert_eq!(colors_set.len(), 3); | ||
| /// ``` | ||
| assert_eq!(colors_set.len(), 3); |
There was a problem hiding this comment.
this line seems to be a mistake?
There was a problem hiding this comment.
Yep. Fixed in latest push
frewsxcv
force-pushed
the
fromiterator-example
branch
from
f6d1ad8 to
8fe7f1f
Compare
|
@bors: r+ rollup |
|
📌 Commit 8fe7f1f has been approved by |
bors
added a commit
that referenced
this pull request
Mar 29, 2015
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.