Renamed Arc::try_unique to get_mut #24053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
Hmm, the doc check gives me these errors, which I don't know how to fix: ---- arc::get_mut_0 stdout ----
<anon>:6:22: 6:27 error: unresolved import `alloc::arc::Arc`. Did you mean `self::alloc::arc`?
<anon>:6 use alloc::arc::{Arc, get_mut};
^~~~~
<anon>:6:27: 6:32 error: unresolved import `alloc::arc::get_mut`. Did you mean `self::alloc::arc`?
<anon>:6 use alloc::arc::{Arc, get_mut};
^~~~~ |
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// # #![feature(alloc)] | ||
| /// extern crate alloc; | ||
| /// # fn main() { |
There was a problem hiding this comment.
I think you'll want to leave this fn main wrapper as otherwise the extern crate alloc is injected into the wrong scope.
There was a problem hiding this comment.
Ok, that explains it ;)
kvark
force-pushed
the
get_mut
branch
2 times, most recently
from
f9a4d31 to
ec8faf2
Compare
|
@alexcrichton Please have another look. |
|
⌛ Testing commit bc1aef3 with merge 6d78aa6... |
|
💔 Test failed - auto-mac-64-nopt-t |
Might be an intermittent? |
|
This error seems unrelated |
|
@bors: retry |
|
(If it passes this time around, we should file it as an intermittent) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @kballard in #23844