Model lexer: Fix remaining issues #24620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completed XID_Start and XID_Continue rules
|
cc @fhahn |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@ pczarn 👍, thanks for taking the time to complete this :) |
|
cc @cmr Looks like there are some tidy errors, but nice work! |
pczarn
force-pushed
the
model-lexer-issues
branch
from
070c8e1 to
13bc8af
Compare
|
Updated |
|
Nice work! I'm pleased to see this :) @bors r+ rollup |
|
📌 Commit 13bc8af has been approved by |
| let mut token_file = File::open(&Path::new(args[2])); | ||
| let token_map = parse_token_list(token_file.read_to_string().unwrap()); | ||
| let surrogate_pairs_pos: Vec<usize> = code.chars().enumerate() | ||
| .filter(|&(_, c)| c as usize > 0xFFFF) |
There was a problem hiding this comment.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15679
Fixes #15878
Fixes #15882
Closes #15883