Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

LLVM < 3.5 is unsupported since bb18a3c #24635

Merged
merged 1 commit into from
Apr 22, 2015
Merged

LLVM < 3.5 is unsupported since bb18a3c #24635

merged 1 commit into from
Apr 22, 2015
+18 −91

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Apr 20, 2015

@dotdash
Copy link
Contributor

dotdash commented Apr 20, 2015

Iff this is to be merged, the ifdef'd code in the custom C bindings should
also be removed.
Am 20.04.2015 20:36 schrieb "Tamir Duberstein" notifications@github.com:

r? @alexcrichton https://github.com/alexcrichton

You can view, comment on, or merge this pull request online at:

#24635
Commit Summary

  • LLVM < 3.5 is unsupported since bb18a3c

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#24635.

@tamird
Copy link
Contributor Author

tamird commented Apr 20, 2015

@dotdash done

@alexcrichton
Copy link
Member

@bors: r+ 8ad5ad4

Thanks!

@bors
Copy link
Contributor

bors commented Apr 21, 2015

⌛ Testing commit 8ad5ad4 with merge d32a7d4...

@bors
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-linux-64-nopt-t

@tamird tamird force-pushed the llvm-3.5 branch 2 times, most recently from 31b4f02 to 01dfdbd Compare April 21, 2015 05:11
@tamird
Copy link
Contributor Author

tamird commented Apr 21, 2015

had an errant #elif instead of an #else. I don't suppose @bors r=alexcrichton is going to work...

@alexcrichton
Copy link
Member

@bors: r+ 01dfdbd

Yeah @bors only recognizes a whitelisted group of reviewers, but pings are good at getting attention :)

@bors
Copy link
Contributor

bors commented Apr 21, 2015

⌛ Testing commit 01dfdbd with merge 08e64e0...

@bors
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-linux-64-x-android-t

@tamird
Copy link
Contributor Author

tamird commented Apr 21, 2015

@alexcrichton had a spurious closing brace; would you re-approve please?

@alexcrichton
Copy link
Member

@bors: r+ ba276ad

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 21, 2015
@alexcrichton
rollup merge of rust-lang#24635: tamird/llvm-3.5
d14fb2f 
r? @alexcrichton
@bors bors merged commit ba276ad into rust-lang:master Apr 22, 2015
@tamird tamird deleted the llvm-3.5 branch April 22, 2015 06:39
@sanxiyn sanxiyn mentioned this pull request May 31, 2015
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tamird @dotdash @alexcrichton @bors