Mention --enable-optimize for --enable-debug #24902
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bombless
changed the title
|
Update: Moved content/rant to https://internals.rust-lang.org/t/why-is-enable-debug-implying-disable-optimize-for-rustc/1978 Sorry for the attempted hijack of the comment thread. |
|
(Arguably I really should not be using github comments for this argument and hijacking a well-meaning pull request like this, which is certainly an improvement over the status quo. I'll copy the above comment to an internals post instead.) |
| @@ -544,7 +544,7 @@ fi | |||
| BOOL_OPTIONS="" | |||
| VAL_OPTIONS="" | |||
|
|
|||
| opt debug 0 "debug mode" | |||
| opt debug 0 "debug mode; you may also want extra --enable-optimize for this as it disable optimization by default" | |||
There was a problem hiding this comment.
First, grammatical typo: "as it disable optimization by default" is not correct. perhaps you meant "... it disables ..." ?
Second: Its pretty long; it gets out to column 114 in my editor, and so it will pretty long in the users terminal. I'm not sure if we have other help text for configure that is so long on one line.
Third: the word "it" in the output is slightly ambiguous; a naive user might think that the word "it" there refers to the --enable-optimize option. (Yes, i know that would be a silly interpretation.)
Maybe better text would be just:
"debug mode; disables optimization unless `--enable-optimize` given"
|
@pnkfelix , thanks for your patience :) |
Closes #24840