-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Document #[repr] on non-C-like enums #25651
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Test that explicit discriminant sizing inhibits the non-nullable pointer | ||
// optimization in enum layout. | ||
|
||
use std::mem::size_of; | ||
|
||
#[repr(i8)] | ||
enum Ei8<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(u8)] | ||
enum Eu8<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(i16)] | ||
enum Ei16<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(u16)] | ||
enum Eu16<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(i32)] | ||
enum Ei32<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(u32)] | ||
enum Eu32<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(i64)] | ||
enum Ei64<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(u64)] | ||
enum Eu64<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(isize)] | ||
enum Eint<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(usize)] | ||
enum Euint<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
#[repr(C)] | ||
enum EC<T> { | ||
_None, | ||
_Some(T), | ||
} | ||
|
||
pub fn main() { | ||
assert_eq!(size_of::<Ei8<()>>(), 1); | ||
assert_eq!(size_of::<Eu8<()>>(), 1); | ||
assert_eq!(size_of::<Ei16<()>>(), 2); | ||
assert_eq!(size_of::<Eu16<()>>(), 2); | ||
assert_eq!(size_of::<Ei32<()>>(), 4); | ||
assert_eq!(size_of::<Eu32<()>>(), 4); | ||
assert_eq!(size_of::<Ei64<()>>(), 8); | ||
assert_eq!(size_of::<Eu64<()>>(), 8); | ||
assert_eq!(size_of::<Eint<()>>(), size_of::<isize>()); | ||
assert_eq!(size_of::<Euint<()>>(), size_of::<usize>()); | ||
|
||
let ptrsize = size_of::<&i32>(); | ||
assert!(size_of::<Ei8<&i32>>() > ptrsize); | ||
assert!(size_of::<Eu8<&i32>>() > ptrsize); | ||
assert!(size_of::<Ei16<&i32>>() > ptrsize); | ||
assert!(size_of::<Eu16<&i32>>() > ptrsize); | ||
assert!(size_of::<Ei32<&i32>>() > ptrsize); | ||
assert!(size_of::<Eu32<&i32>>() > ptrsize); | ||
assert!(size_of::<Ei64<&i32>>() > ptrsize); | ||
assert!(size_of::<Eu64<&i32>>() > ptrsize); | ||
assert!(size_of::<Eint<&i32>>() > ptrsize); | ||
assert!(size_of::<Euint<&i32>>() > ptrsize); | ||
|
||
assert!(size_of::<EC<&i32>>() > ptrsize); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thread '<main>' panicked at 'assertion failed:
(left == right)(left:
4, right:
8)', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/test/run-pass/enum-discrim-manual-sizing-2.rs:89
on 32-bit. Looks like there is a bug in
#[repr]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yes, that sounds like a bug in
#[repr]