rustc_lint: handle more method calls in unconditional_recursion. #26783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #26757) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #27066) made this pull request unmergeable. Please resolve the merge conflicts. |
|
ping @huonw (also needs rebase) |
| bcx.fcx.param_substs)) | ||
| def::DefMethod(meth_did) => { | ||
| let method_item = bcx.tcx().impl_or_trait_item(meth_did); | ||
| fn_callee(bcx, match method_item.container() { |
There was a problem hiding this comment.
Could you move the match to a temporary variable (i.e. to not be inline in the function call)?
|
r=me with a rebase and the nit. |
|
@bors r=huonw |
|
📌 Commit 585f0e9 has been approved by |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #26694, the overloaded operator and "impl not known at method lookup time" cases started triggering the lint.
I've also added checks for overloaded autoderef and method calls via paths (i.e.
T::method()).All new 8 test cases did not trigger the lint before #26694.
r? @huonw