Improve register_diagnostics macro

[GuillaumeGomez]

Now the macro argument list can be finished by a comma (not sure this is correct english...).

cc @tamird
r? @bluss

[tamird]

you can also make the comma required by changing the existing thing to ($($code:tt,)*) => (; I'd personally prefer that. Also true of the other nearby macros (i think there are 3 or 4)

[GuillaumeGomez]

I can add this "feature" for others too, of course. However, I like to have choice to finish the macro with or without a comma. Let's see others' opinions.

[emberian]

This looks fine to me. The Rust Way is to always allow trailing comma but never require it, so this seems consistent with that.

[emberian]

@bors: r+ rollup

[bors]

📌 Commit a5d8c43 has been approved by cmr

[emberian]

@bors: r- (pending more changes)

[emberian]

@bors: r+ rollup

[bors]

📌 Commit 6e58043 has been approved by cmr

[bors]

⌛ Testing commit 6e58043 with merge b429d3d...

[bors]

💔 Test failed - auto-mac-64-nopt-t

[alexcrichton]

@bors: retry

On Fri, Jul 17, 2015 at 7:27 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/5754

—
Reply to this email directly or view it on GitHub
#27067 (comment).

[bors]

⌛ Testing commit 6e58043 with merge 0062146...

[bors]

💔 Test failed - auto-linux-64-nopt-t

[alexcrichton]

@bors: retry

On Fri, Jul 17, 2015 at 8:31 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/5684

—
Reply to this email directly or view it on GitHub
#27067 (comment).

[GuillaumeGomez]

Merged in #27098. I close.