Skip to content

Rollup of 5 pull requests #27270

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 26 commits into from
Closed

Conversation

Manishearth and others added 26 commits July 23, 2015 12:45
the object trait matches the required trait during trait selection.  The
existing code was checking that the object trait WOULD match (in a
probe), but never executing the match outside of a probe.

This corrects various regressions observed in the wild, including
issue rust-lang#26952. Fixes rust-lang#26952.
…labnik

@steveklabnik had suggested I do this.

This needs much review -- I tried reducing the informal tone but there's room for improvement.


r? @steveklabnik
…abnik

I'll be adding more commits to this PR as the weekend progresses. Was hoping to make this a mega-PR, but getting some eyes on this early would be nice too.

r? @steveklabnik

r? @eddyb on the object safety bits

cc @michaelsproul

Part of rust-lang#24407
Correct regression in type-inference caused by failing to reconfirm that
the object trait matches the required trait during trait selection.  The
existing code was checking that the object trait WOULD match (in a
probe), but never executing the match outside of a probe.

This corrects various regressions observed in the wild, including
issue rust-lang#26952. Fixes rust-lang#26952.

r? @eddyb 
cc @frankmcsherry
@Manishearth
Copy link
Member Author

@bors r+ p=200 force

@bors
Copy link
Collaborator

bors commented Jul 24, 2015

📌 Commit 352ff41 has been approved by Manishearth

@rust-highfive
Copy link
Contributor

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Collaborator

bors commented Jul 24, 2015

⌛ Testing commit 352ff41 with merge 6f85b6f...

@bors
Copy link
Collaborator

bors commented Jul 25, 2015

💔 Test failed - auto-mac-64-opt

@bors
Copy link
Collaborator

bors commented Jul 25, 2015

☔ The latest upstream changes (presumably #26960) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants