-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
syntax: Implement #![no_core] #27393
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
4d752d2
to
2553459
Compare
@@ -17,12 +17,6 @@ | |||
//! | |||
//! There is no method to automatically inject this prelude, and this prelude is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence could be updated
☔ The latest upstream changes (presumably #27385) made this pull request unmergeable. Please resolve the merge conflicts. |
2553459
to
6eaf38e
Compare
I've also pushed a commit to make |
6eaf38e
to
7b1db8d
Compare
☔ The latest upstream changes (presumably #27406) made this pull request unmergeable. Please resolve the merge conflicts. |
c6abe01
to
5877903
Compare
@bors r+ |
📌 Commit 5877903 has been approved by |
⌛ Testing commit 5877903 with merge ea95ff6... |
💔 Test failed - auto-mac-32-opt |
5877903
to
6ed2a32
Compare
@bors: r=brson On Fri, Jul 31, 2015 at 10:55 AM, bors notifications@github.com wrote:
|
📌 Commit 6ed2a32 has been approved by |
⌛ Testing commit 6ed2a32 with merge 6cd5e85... |
💔 Test failed - auto-linux-64-opt |
6ed2a32
to
df94d26
Compare
@bors: r=brson On Fri, Jul 31, 2015 at 12:33 PM, bors notifications@github.com wrote:
|
📌 Commit df94d26 has been approved by |
⌛ Testing commit df94d26 with merge b0c4634... |
⌛ Testing commit 855ce95 with merge 797d29c... |
💔 Test failed - auto-mac-64-opt |
@bors: retry On Mon, Aug 3, 2015 at 10:39 AM, bors notifications@github.com wrote:
|
8dbe3e0
to
8ec313d
Compare
@bors: r=brson 8ec313d |
This commit is an implementation of [RFC 1184][rfc] which tweaks the behavior of the `#![no_std]` attribute and adds a new `#![no_core]` attribute. The `#![no_std]` attribute now injects `extern crate core` at the top of the crate as well as the libcore prelude into all modules (in the same manner as the standard library's prelude). The `#![no_core]` attribute disables both std and core injection. [rfc]: rust-lang/rfcs#1184
⌛ Testing commit 8ec313d with merge 31efc19... |
💔 Test failed - auto-mac-64-nopt-t |
8ec313d
to
606d60e
Compare
@bors: r=brson 606d60e |
⌛ Testing commit 606d60e with merge 1f6cc16... |
💔 Test failed - auto-linux-64-x-android-t |
../src/libstd/sys/unix/thread.rs:169:9: 169:24 error: unused import, On Tue, Aug 4, 2015 at 12:38 PM, bors notifications@github.com wrote:
|
This commit removes the injection of `std::env::args()` from `--test` expanded code, relying on the test runner itself to call this funciton. This is more hygienic because we can't assume that `std` exists at the top layer all the time, and it meaks the injected test module entirely self contained.
606d60e
to
0d83403
Compare
This commit is an implementation of [RFC 1184][rfc] which tweaks the behavior of the `#![no_std]` attribute and adds a new `#![no_core]` attribute. The `#![no_std]` attribute now injects `extern crate core` at the top of the crate as well as the libcore prelude into all modules (in the same manner as the standard library's prelude). The `#![no_core]` attribute disables both std and core injection. [rfc]: rust-lang/rfcs#1184 Closes #27394
This commit is an implementation of RFC 1184 which tweaks the behavior of
the
#![no_std]
attribute and adds a new#![no_core]
attribute. The#![no_std]
attribute now injectsextern crate core
at the top of the crateas well as the libcore prelude into all modules (in the same manner as the
standard library's prelude). The
#![no_core]
attribute disables both std andcore injection.
Closes #27394