-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
std: Add into_raw_os traits to the OS preludes #27896
Conversation
These traits were mistakenly left out of the OS-specific prelude modules when they were added.
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
I'm not clear on when we are allowed to upgrade the various preludes. The main prelude does not get updated. When is it ok to update the I/O and OS preludes? |
I believe we're okay with updating all non-default preludes because people have to opt-in to glob importing out of them. |
Yes strictly speaking this is a breaking change because you could have your own |
@bors r+ |
📌 Commit 708200c has been approved by |
⌛ Testing commit 708200c with merge 5fadab6... |
💔 Test failed - auto-linux-32-nopt-t |
@bors: retry On Sat, Aug 22, 2015 at 7:29 AM bors notifications@github.com wrote:
|
These traits were mistakenly left out of the OS-specific prelude modules when they were added.
These traits were mistakenly left out of the OS-specific prelude modules when
they were added.