Handle gateage of built-in attributes seperately #28077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
This allows marking attributes as whitelisted/crate-only independent of their feature gate status. Closes #24213
| ("link_section", Whitelisted, Ungated), | ||
| ("no_builtins", Whitelisted, Ungated), | ||
| ("no_mangle", Whitelisted, Ungated), | ||
| ("no_debug", Whitelisted, Ungated), |
There was a problem hiding this comment.
Hm, not related to the patch, but I wonder if some of these debug things should be gated... (Edit: opened #28091.)
|
@bors r+ Thanks! |
|
📌 Commit 4b571b0 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 29, 2015
This allows marking attributes as whitelisted/crate-only independent of their feature gate status. Closes #24213
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows marking attributes as whitelisted/crate-only independent of
their feature gate status.
Closes #24213