Skip to content

Split out the type lints into a new module #28580

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 23, 2015

Conversation

wesleywiser
Copy link
Member

Move out the TypeLimits and ImproperCTypes lints into a separate module.

Part of #22206

@rust-highfive
Copy link
Contributor

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ b0bcde4

@bors
Copy link
Collaborator

bors commented Sep 22, 2015

⌛ Testing commit b0bcde4 with merge 451c5b4...

@bors
Copy link
Collaborator

bors commented Sep 22, 2015

💔 Test failed - auto-linux-32-opt

@wesleywiser
Copy link
Member Author

@alexcrichton Here's the failing test:

failures:

---- [compile-fail] compile-fail/issue-17546.rs stdout ----

error: expected error: on line 22 not found: found value `foo::MyEnum::NoResult` used as a type
status: exit code: 101
command: i686-unknown-linux-gnu/stage2/bin/rustc /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/test/compile-fail/issue-17546.rs -L i686-unknown-linux-gnu/test/compile-fail/ --target=i686-unknown-linux-gnu -L i686-unknown-linux-gnu/test/compile-fail/issue-17546.stage2-i686-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o i686-unknown-linux-gnu/test/compile-fail/issue-17546.stage2-i686-unknown-linux-gnu --cfg rtopt -O -L i686-unknown-linux-gnu/rt
stdout:
------------------------------------------
thread 'rustc' panicked at 'assertion failed: probe.index() != ib + size + 1', ../src/libstd/collections/hash/map.rs:1204



------------------------------------------
stderr:
------------------------------------------
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
note: run with `RUST_BACKTRACE=1` for a backtrace

------------------------------------------

thread '[compile-fail] compile-fail/issue-17546.rs' panicked at 'explicit panic', /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-opt/build/src/compiletest/runtest.rs:1501



failures:
    [compile-fail] compile-fail/issue-17546.rs

I don't think this is caused by my changes. Am I missing something?

@alexcrichton
Copy link
Member

@bors: retry

ah yeah that just looks spurious

@bors
Copy link
Collaborator

bors commented Sep 23, 2015

⌛ Testing commit b0bcde4 with merge cefe5f2...

bors added a commit that referenced this pull request Sep 23, 2015
Move out the `TypeLimits` and `ImproperCTypes` lints into a separate module. 

Part of #22206
@bors bors merged commit b0bcde4 into rust-lang:master Sep 23, 2015
@wesleywiser wesleywiser deleted the split_out_type_lints branch September 23, 2015 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants