Check attribute usage #28650
Merged
Check attribute usage #28650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
sanxiyn
force-pushed
the
attr-usage
branch
2 times, most recently
from
ab80e64 to
fb22683
Compare
|
r? @nrc |
alexcrichton
added
the
relnotes
|
Starting a crater build to evaluate the impact |
|
Looks like there's only one regression, so should be easy to send a PR for! |
|
I’d replace error message wording from “should” to “may only” or “may”. Otherwise always 👍 for such correctness PRs. |
| if words.is_none() { | ||
| return; | ||
| } | ||
| let words = words.unwrap(); |
There was a problem hiding this comment.
nit:
let words = match attr.meta_item_list() {
Some(words) => words,
None => {
return;
}
};
|
r=me with the style nit fixed |
sanxiyn
force-pushed
the
attr-usage
branch
2 times, most recently
from
c04e6d9 to
c5a7d17
Compare
|
Done. |
|
@bors: r+ |
|
📌 Commit c5a7d17 has been approved by |
|
⌛ Testing commit c5a7d17 with merge 186df85... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors r=nrc |
|
📌 Commit 61f5b2b has been approved by |
|
IMO we should have made this a warning for one release cycle, but I guess this is fine too. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a [breaking-change].
Fix #2809.
Fix #22746.