Skip to content

Fix up docs for char #30013

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Fix up docs for char #30013

merged 1 commit into from
Nov 25, 2015

Conversation

steveklabnik
Copy link
Member

Part of #29333

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Nov 23, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 23, 2015

📌 Commit f6394d8 has been approved by brson

///
/// As always, remember that a human intutition for 'character' may not map to
/// unicode's definitions. For example, emoji symbols such as '❤️' are more than
/// one byte: ❤️ in particular is six:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp. intuition. Maybe the double comma can be relieved with using ; for the first

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, and added the ;, thanks

@steveklabnik
Copy link
Member Author

@bors: r=brson rollup

@bors
Copy link
Collaborator

bors commented Nov 23, 2015

📌 Commit 4c6520c has been approved by brson

/// [`String`]: string/struct.String.html
///
/// As always, remember that a human intuition for 'character' may not map to
/// unicode's definitions. For example, emoji symbols such as '❤️' are more than
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/unicode's/Unicode's/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you always find one :) thanks

@steveklabnik
Copy link
Member Author

@bors: r=brson rollup

@bors
Copy link
Collaborator

bors commented Nov 23, 2015

📌 Commit b65edad has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 24, 2015
@Manishearth
Copy link
Member

@bors r-

<stdin>:1:13: 1:15 error: character literal may only contain one codepoint: '❤
<stdin>:1 let heart = '❤️';

@steveklabnik
Copy link
Member Author

When did that ignore go away? :(

@steveklabnik
Copy link
Member Author

It is marked as ignore, and also, rustdoc --test src/libstd/lib.rs passes. So I dunno what's up here.

@apasel422
Copy link
Contributor

@Manishearth Is there an issue filed for the bad span on that error message?

@steveklabnik
Copy link
Member Author

Fixed a tidy error. Gonna wait and see what travis says before i re-approve though.

@Manishearth
Copy link
Member

@apasel422 I do recall seeing some issue about emoji and stuff messing up spans before, but I don't remember what it was called. I'll look for it.

@apasel422
Copy link
Contributor

@Manishearth For what it's worth, this also has a bad error message:

let x = 'ab';
error: character literal may only contain one codepoint: ';

@steveklabnik
Copy link
Member Author

Travis hasn't passed, but a make check passed on my machine.

@bors: r=brson

@bors
Copy link
Collaborator

bors commented Nov 24, 2015

📌 Commit 4bcf7a5 has been approved by brson

@steveklabnik
Copy link
Member Author

@bors: rollup-

@steveklabnik
Copy link
Member Author

So it passes tests but not generation: #30032

@steveklabnik
Copy link
Member Author

I've re-worded this so that it works now. I should start generating the docs as well as just running the doc tests :/

@bors: r=brson rollup

@bors
Copy link
Collaborator

bors commented Nov 24, 2015

📌 Commit 10c6737 has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 25, 2015
bors added a commit that referenced this pull request Nov 25, 2015
@bors bors merged commit 10c6737 into rust-lang:master Nov 25, 2015
@steveklabnik steveklabnik deleted the doc_char branch June 19, 2016 20:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants