-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix up docs for char #30013
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix up docs for char #30013
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit f6394d8 has been approved by |
/// | ||
/// As always, remember that a human intutition for 'character' may not map to | ||
/// unicode's definitions. For example, emoji symbols such as '❤️' are more than | ||
/// one byte: ❤️ in particular is six: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sp. intuition. Maybe the double comma can be relieved with using ;
for the first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, and added the ;, thanks
f6394d8
to
4c6520c
Compare
@bors: r=brson rollup |
📌 Commit 4c6520c has been approved by |
/// [`String`]: string/struct.String.html | ||
/// | ||
/// As always, remember that a human intuition for 'character' may not map to | ||
/// unicode's definitions. For example, emoji symbols such as '❤️' are more than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/unicode's/Unicode's/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you always find one :) thanks
4c6520c
to
b65edad
Compare
@bors: r=brson rollup |
📌 Commit b65edad has been approved by |
@bors r-
|
When did that |
It is marked as ignore, and also, |
@Manishearth Is there an issue filed for the bad span on that error message? |
b65edad
to
4bcf7a5
Compare
Fixed a tidy error. Gonna wait and see what travis says before i re-approve though. |
@apasel422 I do recall seeing some issue about emoji and stuff messing up spans before, but I don't remember what it was called. I'll look for it. |
@Manishearth For what it's worth, this also has a bad error message: let x = 'ab';
|
Travis hasn't passed, but a @bors: r=brson |
📌 Commit 4bcf7a5 has been approved by |
@bors: rollup- |
9c86832
to
4bcf7a5
Compare
So it passes tests but not generation: #30032 |
4bcf7a5
to
10c6737
Compare
I've re-worded this so that it works now. I should start generating the docs as well as just running the doc tests :/ @bors: r=brson rollup |
📌 Commit 10c6737 has been approved by |
Part of #29333