Skip to content

add tests for #26873 #30408

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 19, 2015
Merged

add tests for #26873 #30408

merged 1 commit into from
Dec 19, 2015

Conversation

durka
Copy link
Contributor

@durka durka commented Dec 16, 2015

I think we can close #26873 with these tests.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Looks like there are some tidy errors (license related), but other than that lgtm

@durka
Copy link
Contributor Author

durka commented Dec 16, 2015

Bah, 2/2 so far on forgetting to copy the license into tests.

@durka
Copy link
Contributor Author

durka commented Dec 16, 2015

Fixed, I think.

@alexcrichton
Copy link
Member

@bors: r+ 88ed7b7

Manishearth added a commit to Manishearth/rust that referenced this pull request Dec 16, 2015
@durka
Copy link
Contributor Author

durka commented Dec 16, 2015

That test failure makes no sense.

@durka
Copy link
Contributor Author

durka commented Dec 16, 2015

@bors retry

@durka
Copy link
Contributor Author

durka commented Dec 16, 2015

@alexcrichton could you restart the test? I think it started in the middle of a force-push or something.

Manishearth added a commit to Manishearth/rust that referenced this pull request Dec 17, 2015
@alexcrichton
Copy link
Member

This is in the queue, it just hasn't hit bors yet

@durka
Copy link
Contributor Author

durka commented Dec 17, 2015

Oh, got it.

@Manishearth
Copy link
Member

@mitaa
Copy link
Contributor

mitaa commented Dec 18, 2015

I did some printf debugging:
Rust is for some reason looking for the module in the directory /home/mitaa/dev/rust instead of /home/mitaa/dev/rust/src/test/run-pass when running the pretty test

I guess // ignore-pretty should be acceptable for now (like the few other tests with mod directives)

bors added a commit that referenced this pull request Dec 18, 2015
@durka
Copy link
Contributor Author

durka commented Dec 18, 2015

Seems like a bug in the prettifier. Anyway, workaround added.

@alexcrichton
Copy link
Member

@bors: r+ 3da609f

@bors
Copy link
Collaborator

bors commented Dec 19, 2015

⌛ Testing commit 3da609f with merge fec739b...

bors added a commit that referenced this pull request Dec 19, 2015
I think we can close #26873 with these tests.
@bors bors merged commit 3da609f into rust-lang:master Dec 19, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unresolved import using separate files, but not mod statements
7 participants