Improve OwnedSlice and use it in HIR (take 2) #30470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochenkov
force-pushed
the
owned5
branch
2 times, most recently
from
b225678 to
e3da2a9
Compare
|
lgtm, how did you fix the segfault? @bors: r+ |
|
📌 Commit e3da2a9 has been approved by |
By not doing this (I also reduced the changes to a necessary minimum, just to be sure). |
|
Also, rr wasn't especially more helpful than vanilla gdb, because it is a release-only segfault - it's still not clear what happens even if the error location is known, the amount of available debuginfo is vanishingly small. After spending some time trying to do assembly level debugging I gave up and spent some machine time instead by bisecting the changes and running make check. |
bors
added a commit
that referenced
this pull request
Dec 20, 2015
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #30095
r? @nrc