-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fixes #30521 and #30627 by adding new snapshots #30643
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Fixes #30627 too. |
Was this intentionally merged into master? |
@dhuseby I build the 2015-12-18 snapshot for DragonFly: You only need to patch the SIGSTACKSZ thing, then it builds fine, IIRC. I also have pushed some patches to https://github.com/rust-lang-nursery/libc, which should help with building more recent versions of Rust (it is broken on libc). |
@dhuseby : If you need help with setting up continuous builds for DragonFly, please let me know. |
@mneumann i will for sure. so far it seems to be going well. |
@dhuseby : cool! Also feel free to submit a patch to etc/snapshots.txt for DragonFly :) |
@mneumann I will add the dragonfly snapshot as soon as I can figure out how to get it to build at the last snap rev. |
@dhuseby : Ok, IIRC I had to patch SIGSTACKSZ constant in rust's libc. I just had to unfold it manually to it's value. |
Did anyone answer @sfackler 's question above? Was there a reason this was directly pushed to master rather than going through bors? (And I don't see any r+'s... ?) |
(having said that, the change seems pretty innocent...) |
@pnkfelix it's because i'm dumb sometimes and i clicked the "merge" button here in github. |
@pnkfelix what's the correct way to merge a PR into bors? |
"@bors r+" |
@sfackler thanks! |
Thanks for the snapshots @dhuseby and @mneumann! It looks like @dhuseby's snapshots have been uploaded (by @brson I guess?), but @mneumann it looks like the DragonFly snapshot is still missing and your link unfortunately has a host name that doesn't resolve for me. (in the future as well, could you guys also paste the sha256 with the links as well?) And yeah @dhuseby just be careful not to merge manually, but no worries! |
@alexcrichton : I pushed the snapshot to @dhuseby 's repo. Then we both opened a pull requests probably at the same time. Next time sha256 👍 |
@mneumann cool, thanks! I've uploaded that snapshot now |
@alexcrichton please upload the following snapshots when landing this patch:
I'm still working on dragonfly bsd. it needs some maintenance love.
thanks!