[MIR] Avoid some code generation for stores of ZST #30848
Merged
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
force-pushed
the
mir-no-store-zsts
branch
from
8aece30 to
2265f32
Compare
|
Updated. |
| @@ -160,7 +160,6 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { | |||
| // stack. | |||
|
|
|||
| let o = self.trans_operand(bcx, operand); | |||
| self.store_operand(bcx, lldest, o); | |||
nagisa
force-pushed
the
mir-no-store-zsts
branch
from
2265f32 to
20618d0
Compare
|
@bors r+ |
|
📌 Commit 20618d0 has been approved by |
|
⌛ Testing commit 20618d0 with merge dce34e7... |
|
⛄ The build was interrupted to prioritize another pull request. |
bors
added a commit
that referenced
this pull request
Jan 14, 2016
|
⌛ Testing commit 20618d0 with merge e5bab5d... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors retry |
|
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30831
r? @nikomatsakis