Skip to content

Do not ignore the test on MSVC #30921

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Jan 14, 2016

The sprintf is indeed not a proper function in VS 2015, but there’s a equivalent wsprintfA function in the user32, which can be used.

I’m primarily submitting this PR to see what happens on the 64bit MSVC buildbot, so I have less things to check once I summon a Windows machine for failures on #30845. If this PR fails to land, then we possibly mistranslate variadic functions for MSVC target. If this PR passes, I can be sure the issue there is restricted to MIR translator and reduce my debugging workload considerably.

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ 5d2f295

Nice find!

@nagisa
Copy link
Member Author

nagisa commented Jan 15, 2016

@bors r-

So it indeed fails. We have an issue with our translation, then.

@nagisa
Copy link
Member Author

nagisa commented Jan 15, 2016

I guess I’ll fix the underlying issue and reenable this test in my other PR, since I’m fixing it anyway.

@nagisa nagisa closed this Jan 15, 2016
bors added a commit that referenced this pull request Jan 15, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants