-
Notifications
You must be signed in to change notification settings - Fork 13.4k
1.7 release notes #31099
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
1.7 release notes #31099
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Please review @rust-lang/libs @rust-lang/lang @rust-lang/compiler |
I'm not mentioning new unstable features like |
Big +1 to doing this overall. On Jan 21, 2016, 19:06 -0500, Brian Andersonnotifications@github.com, wrote:
|
[`Vec::as_mut_slice`], | ||
[`String::as_str`], | ||
[`String::as_mut_str`], | ||
`<[T]>::`[`clone_from_slice`], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good place for a note about new behavior in clone_from_slice
? It should say that clone_from_slice
now requires the two slices to be the same length (and panics otherwise).
@@ -1,3 +1,353 @@ | |||
Version 1.7.0 (2016-03-03) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to make it more obvious this hasn't been released yet and that this is technically a draft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea, but I think I won't do it. It would require patching both the beta and master branches later.
r=me once you feel this is good to go |
[`collections::hash_set::HashSet::drain`], | ||
[`collections::binary_heap::Drain`], | ||
[`collections::binary_heap::BinaryHeap::drain`], | ||
[`Vec::extend_from_slice`] (renamed from `push_all`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a []
after the ]
here.
@bors r=alexcrichton |
📌 Commit 6dbff05 has been approved by |
[`i32::overflowing_shl`], | ||
[`i32::overflowing_shr`], | ||
[`u32::checked_rem`], | ||
[`u32::checked_neg`], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is missing a url
⌛ Testing commit 6dbff05 with merge 24cd6a3... |
⛄ The build was interrupted to prioritize another pull request. |
@bors: rollup Sorry I interrupted to see if I can get the LLVM upgrade to land or otherwise the bots are just gonna keep oscillating back and forth between various versions of LLVM. It may not work out though... |
⌛ Testing commit 6dbff05 with merge 43ee048... |
💔 Test failed - auto-linux-cross-opt |
@bors: retry On Fri, Jan 29, 2016 at 9:23 PM, bors notifications@github.com wrote:
|
No description provided.