Skip to content

Revert "mk: fix some undefined variable warnings" #31361

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

alexcrichton
Copy link
Member

This reverts commit d037129.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

This reverts #30367 which looks like it unfortunately caused a 1hr long regression in testing time on the bots (compare this short build to this long build).

I may try to investigate later, but seems good to at least get the cycle time back down for now.

cc @tamird

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Feb 2, 2016
@tamird
Copy link
Contributor

tamird commented Feb 2, 2016

:(

@brson
Copy link
Contributor

brson commented Feb 2, 2016

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Feb 2, 2016

📌 Commit 178d4b0 has been approved by brson

@Manishearth
Copy link
Member

@bors p=20

bors added a commit that referenced this pull request Feb 2, 2016
@bors bors merged commit 178d4b0 into rust-lang:master Feb 3, 2016
@alexcrichton alexcrichton deleted the revert-mk-changes branch February 8, 2016 23:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants