configure: require Python 2.7 #31640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| fi | ||
|
|
||
| python_version=$($CFG_PYTHON -V 2>&1) | ||
| if [ $(echo $python_version | grep -c '^Python 2\.[4567]') -ne 1 ]; then | ||
| err "Found $python_version, but LLVM requires Python 2.4-2.7" | ||
| if [ $(echo $python_version | grep -c '^Python 2.7') -ne 1 ]; then |
There was a problem hiding this comment.
This change is deliberately as conservative as possible. It might be possible to write it more elegantly now that a single fixed string is expected, but I am afraid of breaking things. I tested it locally and it seems to work, but I am a shell noob.
There was a problem hiding this comment.
I think that you should escape the . (like in the old code) and match against '^Python 2\.7', otherwise the test will also accept strings like Python 217 (which is probably not going to be a problem ever)
There was a problem hiding this comment.
Oh, derp. Fixed.
In other words, enforce what was documented in rust-lang#30626 (and also stop blaming it on LLVM, we have at least one Python script of our own). Also, there is no Python later than 2.7 and there never will be.
hanna-kruppe
force-pushed
the
require-py27
branch
from
a6416fd to
999051d
Compare
|
@bors r+ |
|
📌 Commit 999051d has been approved by |
bors
added a commit
that referenced
this pull request
Feb 15, 2016
In other words, enforce what was documented in #30626 (and also stop blaming it on LLVM, we have at least one Python script of our own). Also, there is no Python later than 2.7 and there never will be.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words, enforce what was documented in #30626 (and also stop blaming it on LLVM, we have at least one Python script of our own).
Also, there is no Python later than 2.7 and there never will be.