-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Revert ObligationForest on beta branch #31851
Conversation
…, r=aturon" This reverts commit c14b615, reversing changes made to dda25f2. This caused a regression in compiler performance and backporting the fix to beta was deemed too risky and too challenging, since it is non-trivial and builds on prior commits in various ways. Conflicts: src/librustc/middle/traits/fulfill.rs src/librustc_data_structures/lib.rs
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Hmm, local testing of this PR has encountered some odd failures (e.g., a segfault just now in the libcollections tests). But I am sort of reluctant to blame it on this PR to be honest. |
I'm testing locally. |
Actually, I see the same problem whether or not this commit is applied:
|
I don't see the crash locally. |
OK, I don't know what's happening locally, but I'm inclined to take this PR. |
Revert ObligationForest on beta branch
The OF caused a regression in compiler performance and backporting the fix
to beta was deemed too risky and too challenging, since it is
non-trivial and builds on prior commits in various ways.