Skip to content

doc: remove needless bindings #32440

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2016
Merged

doc: remove needless bindings #32440

merged 1 commit into from
Mar 26, 2016

Conversation

tshepang
Copy link
Member

The extra syntax is more noise than help in simple examples like this

@rust-highfive
Copy link
Contributor

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik
steveklabnik reviewed Mar 23, 2016
View reviewed changes
src/librustc_unicode/char.rs
/// // love is many things, but it is not alphabetic
/// assert!(!c.is_alphabetic());
/// assert!(!'❤️'.is_alphabetic());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing my heart, tisk tisk! 😉

@steveklabnik
Copy link
Member

So, I think I feel good about this change, but I'm not sure. @GuillaumeGomez , what do you think?

@GuillaumeGomez
Copy link
Member

In this case, it's obvious we're working on chars so the binding seems useless for me as well. I'm all for it! :)

@steveklabnik
Copy link
Member

The heart change is actually breaking; 💖 is a char, but ❤️ isn't.

@eddyb
Copy link
Member

eddyb commented Mar 23, 2016

@steveklabnik They both are single Unicode codepoints, but @tshepang actually had "\u{2764}\u{fe0f}" - the second codepoint being "Variation Selector 16". It doesn't add the sparkles for me, but some OS with pervasive normalization might cause this on copy/paste.

EDIT: Actually, it's supposed to be "emoji style". Either way, the second codepoint can be safely removed.

@tshepang
Copy link
Member Author

I reverted the weird heart thing

@steveklabnik
Copy link
Member

travis is happy so i am happy. Thanks @tshepang !

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 24, 2016

📌 Commit 2c48214 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
@Manishearth
Rollup merge of rust-lang#32440 - tshepang:compact, r=steveklabnik
b6b2dbd 
doc: remove needless bindings

The extra syntax is more noise than help in simple examples like this
@Manishearth Manishearth mentioned this pull request Mar 26, 2016
Closed
bors added a commit that referenced this pull request Mar 26, 2016
@bors
Auto merge of #32495 - Manishearth:rollup, r=<try>
49312a4 
Rollup of 18 pull requests

- Successful merges: #32131, #32199, #32257, #32325, #32383, #32387, #32432, #32435, #32440, #32447, #32448, #32456, #32468, #32470, #32476, #32478, #32484, #32492
- Failed merges: #32240, #32469, #32482
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
@Manishearth
Rollup merge of rust-lang#32440 - tshepang:compact, r=steveklabnik
887e927 
doc: remove needless bindings

The extra syntax is more noise than help in simple examples like this
@Manishearth Manishearth mentioned this pull request Mar 26, 2016
Merged
bors added a commit that referenced this pull request Mar 26, 2016
@bors
Auto merge of #32508 - Manishearth:rollup, r=Manishearth
8f34053 
Rollup of 6 pull requests

- Successful merges: #32383, #32387, #32440, #32470, #32478, #32492
- Failed merges:
@bors bors merged commit 2c48214 into rust-lang:master Mar 26, 2016
@tshepang tshepang deleted the compact branch March 30, 2016 09:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jroesch jroesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tshepang @rust-highfive @steveklabnik @GuillaumeGomez @eddyb @bors @jroesch