Fix cargotest #32786
Merged
Fix cargotest #32786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 7, 2016
Fix cargotest Tested in dev.
|
@alexcrichton re-r? I made cargotest depend on librustctest because cargo's test suite is looking for librustc_plugins. I swear this is the secret ingredient that will make it all work. Untested ;) |
|
Oh right yeah we have some tests that exercise plugins. This means we can't submit a breaking change to plugins without changing upstream Cargo but... I guess that's not too bad? @bors: r+ |
|
📌 Commit 8019922 has been approved by |
|
Everything passed except android which disappeared again unfortunately, so merging manually. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in dev.